1191098 - Replace AutoHashableValueRooter with Rooted

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: remove_AutoHashableValueRooter-v0.diff

This was fairly straightforward. The only complication is that both Rooted and HashableValue have a |get()| method. I wrapped HashableValue::get() as RooredBase<HashableValue>::value() to avoid the collision.

Comment 1

[Jon Coppeard (:jonco)]

Comment on attachment 8643327 [details] [diff] [review]
remove_AutoHashableValueRooter-v0.diff

Review of attachment 8643327 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: js/src/builtin/MapObject.h
@@ +40,5 @@
>      bool setValue(JSContext* cx, HandleValue v);
>      HashNumber hash() const;
>      bool operator==(const HashableValue& other) const;
>      HashableValue mark(JSTracer* trc) const;
>      Value get() const { return value.get(); }

Not related to this patch, but looks like this should be called value() for symmetry with setValue().

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21c28216e5e7

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/21c28216e5e7