bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Clean up stateWM vs. wm confusion in nsHTMLReflowState::GetHypotheticalBoxContainer

RESOLVED FIXED in Firefox 43

Status

()

Core
Layout
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dholbert, Assigned: jfkthame)

Tracking

Trunk
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
In nsHTMLReflowState::GetHypotheticalBoxContainer, we have two writing-modes -- wm and stateWM -- and we convert between them.

I think they're the writing-mode for the same frame, though (the containing block), so I don't think we actually need both (and I think we can assume they're the same).

So I think we can move...
  WritingMode wm = aFrame->GetWritingMode();
...into the "else" clause (the code for when we have no reflow-state for the containing block), and we can just rename "stateWM" to "wm" in the "if" clause. (and do away with unnecessary WM conversion)

http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsHTMLReflowState.cpp?rev=65c3a87e04fb#1020

Marking as depends-on bug 1183431 because this is in code that's touched by the patch there, and I don't want to bitrot jfkthame, so we shouldn't patch this until after bug 1183431 has landed.
(Assignee)

Comment 1

3 years ago
Created attachment 8644543 [details] [diff] [review]
Clean up use of writing-modes in GetHypotheticalBoxContainer, eliminating a redundant ConvertTo call
Attachment #8644543 - Flags: review?(dholbert)
(Assignee)

Updated

3 years ago
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
(Reporter)

Comment 3

3 years ago
Comment on attachment 8644543 [details] [diff] [review]
Clean up use of writing-modes in GetHypotheticalBoxContainer, eliminating a redundant ConvertTo call

Looks good -- thanks!
Attachment #8644543 - Flags: review?(dholbert) → review+
(Assignee)

Comment 4

3 years ago
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/f4387ef8cabe8a17c490b3554206a5b7513f7945
changeset:  f4387ef8cabe8a17c490b3554206a5b7513f7945
user:       Jonathan Kew <jkew@mozilla.com>
date:       Wed Aug 12 11:02:02 2015 +0100
description:
Bug 1191109 - Clean up use of writing-modes in GetHypotheticalBoxContainer, eliminating a redundant ConvertTo call. r=dholbert
https://hg.mozilla.org/mozilla-central/rev/f4387ef8cabe
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.