1191124 - Refactor Contacts to use modern L10n API

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Similarly to how we get other apps ready for l20n.js, I'd like to update Contacts L10n API uses.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1191124-refactor-contacts-l10n-api > mozilla-b2g:master

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8643395 [details] [review]
[gaia] zbraniecki:1191124-refactor-contacts-l10n-api > mozilla-b2g:master

Borja, I saw you working on a lot of contacts UI updates. This patch is trying to avoid the areas that you've been recently working on, so I hope it doesn't duplicate your work.

It's exclusively cleanups and migrations away from mozL10n.get. I left a couple cases which I think deserve separate patches or seem to be affected by the UI refactor.

Would you be ok reviewing this?

Comment 3

[Borja Salguero [:borjasalguero]]

Comment on attachment 8643395 [details] [review]
[gaia] zbraniecki:1191124-refactor-contacts-l10n-api > mozilla-b2g:master

Hi Zibi! After Paris WW we are quite close to land new UI separation based on NGA architecture, so It would be great to have this patch rebased with the final version of the code (every view is a separate .html with it own JS).

We have plans to land this during this and the following week, and then the code will be ready for this exciting new l10n API! I'll let you know once all patches will be available in master.

Removing r? and adding a ni? to me in order to update this bug properly once the code will be available in master. Thanks!

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Sure!

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Hi Borja, how's the progress with that? 

If you're landing the whole new front end, I'd recommend picking shared/js/l20n.js for localization. If you are reusing old front end code and that uses l10n.js, I'd like to help refactoring that to be ready for the switch to l20n.js

Comment 6

[Borja Salguero [:borjasalguero]]

Let's forward this request to Francisco, due to after the latests changes in NGA we should decide how to move forward here.
Francisco, as we are stuck with the NGA in Contacts due to the lack of pre-rendering, How could we move forward? Thanks!

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

We will need to wait at least this week, until we do the analysis of continuing with splitted documents or rollback.

Once we have final decision we can ask for a rebase on the original PR to continue the process.

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

What's the update here?

I'd be happy to undust the patch against current communications/contacts if you believe that this is the right way to go.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Hi,

so far the way we have been working is landing the patches in master and I was doing cherry picking and updating a branch in gaia called NGA that contains the separated views.

Zibi, will be a lot of work if I ask you for the two versions of the patch? If not I will port it to the nga branch.

The idea is to stop doing any feature work on master for contacts, and once we have the platform ready replace one app with the one from the nga branch. But this work is really needed in both places.

wdyt?

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

Removing obsolete NI.

Also, closing as WONTFIX. Reopen if needed.