Closed Bug 1191130 Opened 9 years ago Closed 3 years ago

Intermittent browser_contentSearchUI.js | Test timed out

Categories

(Firefox :: Search, defect, P5)

Product:
Firefox
Component:
Search
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 54
Tracking Flags:
Tracking Status
firefox52 --- fixed
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: KWierso, Assigned: nhnt11)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed][fxsearch])

Attachments

(3 files)

Bug 1191130 - Make sure we wait for the initial load of new tabs in browser_contentSearchUI.js.
59 bytes, text/x-review-board-request
standard8
: review+
Details
Bug 1191130 - Start listening for response before sending async message. r=pbz
47 bytes, text/x-phabricator-request
Details | Review
Bug 1191130 - [Content Search UI tests] Fix TypeError and add some diagnostic logging. r=adw
47 bytes, text/x-phabricator-request
Details | Review
14:14:00 INFO - 448 INFO TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State 14:14:00 INFO - 449 INFO Leaving test cycleSuggestions 14:14:00 INFO - 450 INFO Entering test cycleOneOffs 14:14:00 INFO - 451 INFO TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State 14:14:00 INFO - 452 INFO TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State 14:14:00 INFO - 453 INFO TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State 14:14:00 INFO - 454 INFO TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State 14:14:00 INFO - 455 INFO TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State 14:14:00 INFO - 456 INFO TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State 14:14:00 INFO - 457 INFO TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State 14:14:00 INFO - 458 INFO TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State 14:14:00 INFO - 459 INFO TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State 14:14:00 INFO - 460 INFO TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State 14:14:00 INFO - 461 INFO TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State 14:14:00 INFO - 462 INFO Leaving test cycleOneOffs 14:14:00 INFO - 463 INFO Entering test mouse 14:14:00 INFO - 464 INFO TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State 14:14:00 INFO - 465 INFO TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State 14:14:00 INFO - 466 INFO TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State 14:14:00 INFO - 467 INFO TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State 14:14:00 INFO - 468 INFO Longer timeout required, waiting longer... Remaining timeouts: 1 14:14:00 INFO - 469 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_contentSearchUI.js | Test timed out - expected PASS 14:14:00 INFO - MEMORY STAT | vsize 1397MB | residentFast 348MB | heapAllocated 140MB 14:14:00 INFO - 470 INFO TEST-OK | browser/base/content/test/general/browser_contentSearchUI.js | took 90960ms 14:14:00 INFO - ++DOCSHELL 0x7fb46ba32800 == 2 [pid = 2275] [id = 246] 14:14:00 INFO - ++DOMWINDOW == 3 (0x7fb46e8d1800) [pid = 2275] [serial = 630] [outer = (nil)] 14:14:00 INFO - 471 INFO TEST-START | browser/base/content/test/general/browser_contextmenu_childprocess.js 14:14:00 INFO - ++DOMWINDOW == 4 (0x7fb46e9ad400) [pid = 2275] [serial = 631] [outer = 0x7fb46e8d1800] 14:14:00 INFO - [Child 2275] WARNING: '!editorRectEvent.mSucceeded', file /builds/slave/b2g-in-l64-d-00000000000000000/build/src/widget/ContentCache.cpp, line 256 14:14:00 INFO - [Child 2275] WARNING: '!mContentCache.CacheEditorRect(this, &aIMENotification)', file /builds/slave/b2g-in-l64-d-00000000000000000/build/src/widget/PuppetWidget.cpp, line 833 14:14:00 INFO - ++DOCSHELL 0x7fb46ba48000 == 3 [pid = 2275] [id = 247]
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
This really spiked around january 17th and I have been working on narrowing down the commit which caused this: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=osx%20e10s%20bc&tochange=148ee5df4dd3138b24d70dfd11b82499beda368c&fromchange=8a7cffb801da9bfcc871d32307ef4338d4074a99&selectedJob=71303312 As for timing out, this typically runs in <10 seconds, so this is not a typical case where we are accidentally adjusting the timing and going 1 second longer to cause a timeout. here is a clip from the log upon failure [0]: 13:04:08 INFO - TEST-START | browser/base/content/test/general/browser_contentSearchUI.js 13:06:23 INFO - TEST-INFO | started process screencapture 13:06:23 INFO - TEST-INFO | screencapture: exit 0 13:06:23 INFO - <snipped 69 output lines - if you need more context, please use SimpleTest.requestCompleteLog() in your test> 13:06:23 INFO - Buffered messages logged at 13:04:09 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - Leaving test bound cycleSuggestions 13:06:23 INFO - Entering test bound cycleOneOffs 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - Leaving test bound cycleOneOffs 13:06:23 INFO - Entering test bound mouse 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - Leaving test bound mouse 13:06:23 INFO - Entering test bound formHistory 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - Leaving test bound formHistory 13:06:23 INFO - Entering test bound cycleEngines 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | Engine cycled correctly - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | Engine cycled correctly - 13:06:23 INFO - Leaving test bound cycleEngines 13:06:23 INFO - Entering test bound search 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | Search event data - 13:06:23 INFO - Buffered messages logged at 13:04:10 13:06:23 INFO - Waiting for ContentSearch message AddToWhitelistAck... 13:06:23 INFO - Received ContentSearch message AddToWhitelistAck 13:06:23 INFO - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | Search event data - 13:06:23 INFO - Waiting for ContentSearch message AddToWhitelistAck... 13:06:23 INFO - Received ContentSearch message AddToWhitelistAck 13:06:23 INFO - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | Search event data - 13:06:23 INFO - Waiting for ContentSearch message AddToWhitelistAck... 13:06:23 INFO - Received ContentSearch message AddToWhitelistAck 13:06:23 INFO - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | Search event data - 13:06:23 INFO - Buffered messages logged at 13:04:11 13:06:23 INFO - Waiting for ContentSearch message AddToWhitelistAck... 13:06:23 INFO - Received ContentSearch message AddToWhitelistAck 13:06:23 INFO - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | Search event data - 13:06:23 INFO - Waiting for ContentSearch message AddToWhitelistAck... 13:06:23 INFO - Received ContentSearch message AddToWhitelistAck 13:06:23 INFO - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | Search event data - 13:06:23 INFO - Buffered messages logged at 13:04:12 13:06:23 INFO - Waiting for ContentSearch message AddToWhitelistAck... 13:06:23 INFO - Received ContentSearch message AddToWhitelistAck 13:06:23 INFO - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | Search event data - 13:06:23 INFO - Waiting for ContentSearch message AddToWhitelistAck... 13:06:23 INFO - Received ContentSearch message AddToWhitelistAck 13:06:23 INFO - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | Search event data - 13:06:23 INFO - Waiting for ContentSearch message AddToWhitelistAck... 13:06:23 INFO - Received ContentSearch message AddToWhitelistAck 13:06:23 INFO - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - Buffered messages logged at 13:04:13 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | Search event data - 13:06:23 INFO - Waiting for ContentSearch message AddToWhitelistAck... 13:06:23 INFO - Received ContentSearch message AddToWhitelistAck 13:06:23 INFO - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | Search event data - 13:06:23 INFO - Waiting for ContentSearch message AddToWhitelistAck... 13:06:23 INFO - Received ContentSearch message AddToWhitelistAck 13:06:23 INFO - 13:06:23 INFO - TEST-PASS | browser/base/content/test/general/browser_contentSearchUI.js | State - 13:06:23 INFO - Buffered messages logged at 13:04:14 13:06:23 INFO - Waiting for ContentSearch message AddToWhitelistAck... 13:06:23 INFO - Buffered messages logged at 13:04:53 13:06:23 INFO - Longer timeout required, waiting longer... Remaining timeouts: 1 13:06:23 INFO - Buffered messages logged at 13:05:29 13:06:23 INFO - Console message: [JavaScript Error: "1485205529280 Toolkit.Telemetry ERROR TelemetrySend::_doPing - error making request to https://127.0.0.1:8888/telemetry-dummy//submit/telemetry/95c05622-cae0-c84d-8e57-9264fad23c8f/deletion/Firefox/53.0a1/default/20170117084124?v=4: timeout" {file: "resource://gre/modules/Log.jsm" line: 748}] 13:06:23 INFO - App_append@resource://gre/modules/Log.jsm:748:9 13:06:23 INFO - log@resource://gre/modules/Log.jsm:386:7 13:06:23 INFO - getLoggerWithMessagePrefix/proxy.log@resource://gre/modules/Log.jsm:501:44 13:06:23 INFO - error@resource://gre/modules/Log.jsm:394:5 13:06:23 INFO - errorhandler@resource://gre/modules/TelemetrySend.jsm:944:7 13:06:23 INFO - EventHandlerNonNull*_doPing@resource://gre/modules/TelemetrySend.jsm:948:5 13:06:23 INFO - TelemetrySendImpl._sendPersistedPings</<@resource://gre/modules/TelemetrySend.jsm:828:27 13:06:23 INFO - process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:917:23 13:06:23 INFO - Promise*scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:734:11 13:06:23 INFO - schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:765:7 13:06:23 INFO - completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:702:7 13:06:23 INFO - onSuccess@resource://gre/modules/osfile/osfile_native.jsm:63:7 13:06:23 INFO - 13:06:23 INFO - Console message: [JavaScript Error: "1485205529281 Toolkit.Telemetry ERROR TelemetrySend::sendPersistedPings - failed to send ping 565eaf47-b486-0647-b7a6-752e5eafe22e: {"isTrusted":true}" {file: "resource://gre/modules/Log.jsm" line: 748}] 13:06:23 INFO - App_append@resource://gre/modules/Log.jsm:748:9 13:06:23 INFO - log@resource://gre/modules/Log.jsm:386:7 13:06:23 INFO - getLoggerWithMessagePrefix/proxy.log@resource://gre/modules/Log.jsm:501:44 13:06:23 INFO - error@resource://gre/modules/Log.jsm:394:5 13:06:23 INFO - TelemetrySendImpl._sendPersistedPings</<@resource://gre/modules/TelemetrySend.jsm:829:23 13:06:23 INFO - process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:920:21 13:06:23 INFO - walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:801:7 13:06:23 INFO - Promise*scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:734:11 13:06:23 INFO - schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:765:7 13:06:23 INFO - completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:702:7 13:06:23 INFO - promise callback*completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:693:7 13:06:23 INFO - process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:953:5 13:06:23 INFO - walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:801:7 13:06:23 INFO - Promise*scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:734:11 13:06:23 INFO - schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:765:7 13:06:23 INFO - completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:702:7 13:06:23 INFO - onSuccess@resource://gre/modules/osfile/osfile_native.jsm:63:7 13:06:23 INFO - 13:06:23 INFO - Buffered messages finished 13:06:23 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_contentSearchUI.js | Test timed out - 13:06:23 INFO - MEMORY STAT | vsize 3606MB | residentFast 560MB | heapAllocated 139MB 13:06:23 INFO - TEST-OK | browser/base/content/test/general/browser_contentSearchUI.js | took 135262ms :nhnt11, can you take a look at this as I see as the original author? Let me know if there is more information you need to help debug this. [0] https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-macosx64/1484671284/mozilla-inbound_yosemite_r7_test-mochitest-e10s-browser-chrome-5-bm132-tests1-macosx-build689.txt.gz
Flags: needinfo?(nhnt11)
promiseTab adds a tab without waiting for the initial load, then loads a URL. In between, it adds a load listener that is intended to pick up the load of the URL, but sometimes it picks up the initial load event instead, causing intermittent timeouts. That's my suspicion anyway, and it's supported by the fact that I went from 100% failure rate to 0% locally. I'll request review once I have a green try push.
Flags: needinfo?(nhnt11)
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Attachment #8830228 - Flags: review?(adw)
Comment on attachment 8830228 [details] Bug 1191130 - Make sure we wait for the initial load of new tabs in browser_contentSearchUI.js. https://reviewboard.mozilla.org/r/107128/#review108546 ::: browser/base/content/test/general/browser_contentSearchUI.js:720 (Diff revision 1) > var gMsgMan; > > -function promiseTab() { > +function* promiseTab() { > let deferred = Promise.defer(); > - let tab = gBrowser.addTab(); > - registerCleanupFunction(() => gBrowser.removeTab(tab)); > + let tab = yield BrowserTestUtils.openNewForegroundTab(gBrowser); > + registerCleanupFunction(() => BrowserTestUtils.removeTab(tab)); shouldn't this be a generator yielding on removeTab?
oh sorry, I forgot registerCleanup also supports a promise :)
I see >500 instances of this on orangefactor for the last week- can we disable or fix this today?
Attachment #8830228 - Flags: review?(adw) → review?(standard8)
Comment on attachment 8830228 [details] Bug 1191130 - Make sure we wait for the initial load of new tabs in browser_contentSearchUI.js. https://reviewboard.mozilla.org/r/107128/#review108938 Stealing review to help this move forward. I've tried this locally and the changes look good for me. r=Standard8
Attachment #8830228 - Flags: review?(standard8) → review+
Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a85aae712956 Make sure we wait for the initial load of new tabs in browser_contentSearchUI.js. r=standard8
https://hg.mozilla.org/mozilla-central/rev/a85aae712956
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Hmm, seems there are still similar-looking timeouts from this test. Adding it to my radar, but not marking this bug reopened just yet.
Flags: needinfo?(nhnt11)
Whiteboard: [stockwell fixed]
Since there are still failures, either this bug should be reopened or a new bug should be filed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
this is creeping up in frequency, :nhnt11 has a ni from ~2 months ago, possibly it is time to put this in a queue to look at in the short term?
Whiteboard: [stockwell fixed] → [stockwell fixed][fxsearch]
Priority: P3 → P5
Flags: needinfo?(nhnt11)
Keywords: leave-open
Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7006b881f891 Start listening for response before sending async message. r=pbz

The latest patch resulted in 4 green verify runs, i.e. 120 successful runs of the test. I retriggered bc1 a bunch of times but they were useless - those retrigger jobs didn't include the test in the run. Apparently retriggers don't play well with fuzzy try syntax.

Anyway, the patch + 4 green TV jobs looks promising so I landed it. I also marked this as leave-open - let's wait a couple of weeks and see if the intermittent failures bot stops complaining before closing the bug.

No failures after the latest patch landed - promising! I'll check back in a couple of weeks to see if this remains stable. needinfo'ing myself as a reminder.

Flags: needinfo?(nhnt11)
Attachment #9096843 - Attachment description: Bug 1191130 - [Content Search UI] Fix TypeError: eng is undefined when setting icon. r=adw → Bug 1191130 - [Content Search UI tests] Fix TypeError and add some diagnostic logging. r=adw
Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3a9cd5c9bc4f [Content Search UI tests] Fix TypeError and add some diagnostic logging. r=adw

I think someone else should take over here, I'm pretty far away from this code and won't have time to take another look any time soon.

Flags: needinfo?(nhnt11)

Forgot to unassign myself in comment 227. Sorry if this interfered with tracking.

Assignee: nhnt11 → nobody

This has gone away again. Lets call it fixed, since we fixed something previously, even if it re-appeared.

Status: REOPENED → RESOLVED
Closed: 8 years ago → 3 years ago
Resolution: --- → FIXED
Assignee: nobody → nhnt11
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: