1191144 - Remove CACHE_SERVICE_LOCK_WAIT_MAINTHREAD_NSCACHESERVICE_LEAVEPRIVATEBROWSING

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[(no longer active)]

This probe can be used to reveal whether the user has been using the private browsing mode, violating their privacy.  This needs to be removed.

Comment 1

[(no longer active)]

Attachment: Remove CACHE_SERVICE_LOCK_WAIT_MAINTHREAD_NSCACHESERVICE_LEAVEPRIVATEBROWSING

Comment 2

[Patrick McManus [:mcmanus]]

Comment on attachment 8643389 [details] [diff] [review]
Remove CACHE_SERVICE_LOCK_WAIT_MAINTHREAD_NSCACHESERVICE_LEAVEPRIVATEBROWSING

Review of attachment 8643389 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/cache/nsCacheService.cpp
@@ -3170,5 @@
>  
>  void
>  nsCacheService::LeavePrivateBrowsing()
>  {
> -    nsCacheServiceAutoLock lock(LOCK_TELEM(NSCACHESERVICE_LEAVEPRIVATEBROWSING));

this seems to remove the lock as well as the telemetry..

michal novotny should probly review next rev.

Comment 3

[(no longer active)]

The lock class just calls Lock() and Unlock() <https://dxr.mozilla.org/mozilla-central/source/netwerk/cache/nsCacheService.h#381> which

Comment 4

[(no longer active)]

Attachment: Remove CACHE_SERVICE_LOCK_WAIT_MAINTHREAD_NSCACHESERVICE_LEAVEPRIVATEBROWSING

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c245eafc48bd

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c245eafc48bd