Closed Bug 1191144 Opened 5 years ago Closed 5 years ago

Remove CACHE_SERVICE_LOCK_WAIT_MAINTHREAD_NSCACHESERVICE_LEAVEPRIVATEBROWSING

Categories

(Core :: Networking: Cache, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file, 1 obsolete file)

This probe can be used to reveal whether the user has been using the private browsing mode, violating their privacy.  This needs to be removed.
Comment on attachment 8643389 [details] [diff] [review]
Remove CACHE_SERVICE_LOCK_WAIT_MAINTHREAD_NSCACHESERVICE_LEAVEPRIVATEBROWSING

Review of attachment 8643389 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/cache/nsCacheService.cpp
@@ -3170,5 @@
>  
>  void
>  nsCacheService::LeavePrivateBrowsing()
>  {
> -    nsCacheServiceAutoLock lock(LOCK_TELEM(NSCACHESERVICE_LEAVEPRIVATEBROWSING));

this seems to remove the lock as well as the telemetry..

michal novotny should probly review next rev.
Attachment #8643389 - Flags: review?(mcmanus) → review-
Attachment #8643389 - Attachment is obsolete: true
Attachment #8643689 - Flags: review?(michal.novotny)
Attachment #8643689 - Flags: review?(michal.novotny) → review+
https://hg.mozilla.org/mozilla-central/rev/c245eafc48bd
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.