Remove CACHE_SERVICE_LOCK_WAIT_MAINTHREAD_NSCACHESERVICE_LEAVEPRIVATEBROWSING

RESOLVED FIXED in Firefox 42

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

This probe can be used to reveal whether the user has been using the private browsing mode, violating their privacy.  This needs to be removed.
Comment on attachment 8643389 [details] [diff] [review]
Remove CACHE_SERVICE_LOCK_WAIT_MAINTHREAD_NSCACHESERVICE_LEAVEPRIVATEBROWSING

Review of attachment 8643389 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/cache/nsCacheService.cpp
@@ -3170,5 @@
>  
>  void
>  nsCacheService::LeavePrivateBrowsing()
>  {
> -    nsCacheServiceAutoLock lock(LOCK_TELEM(NSCACHESERVICE_LEAVEPRIVATEBROWSING));

this seems to remove the lock as well as the telemetry..

michal novotny should probly review next rev.
Attachment #8643389 - Flags: review?(mcmanus) → review-
Attachment #8643389 - Attachment is obsolete: true
Attachment #8643689 - Flags: review?(michal.novotny)
Attachment #8643689 - Flags: review?(michal.novotny) → review+
https://hg.mozilla.org/mozilla-central/rev/c245eafc48bd
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.