1191171 - Add SetVolume() to DecodedStream

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

To be more consistent with AudioSink which also has SetVolume() and we don't have to pass the volume to DecodedStream::SendData().

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5a6ea639d82

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1191171 - Add SetVolume() to DecodedStream.

Bug 1191171 - Add SetVolume() to DecodedStream.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8644094 [details]
MozReview Request: Bug 1191171 - Add SetVolume() to DecodedStream.

https://reviewboard.mozilla.org/r/15223/#review13719

Ship It!

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7115a03c413a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7115a03c413a