Closed Bug 1191173 Opened 4 years ago Closed 4 years ago

Mirror MediaDecoder::mSameOriginMedia in MDSM

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

So we can remove MediaDecoder::IsSameOriginMedia which is called by MDSM on a non-main thread.
Blocks: 1179498
Bug 1191173 - Mirror MediaDecoder::mSameOriginMedia in MDSM.
Attachment #8644095 - Flags: review?(jyavenard)
Blocks: 1191192
Attachment #8644095 - Flags: review?(jyavenard) → review+
Comment on attachment 8644095 [details]
MozReview Request: Bug 1191173 - Mirror MediaDecoder::mSameOriginMedia in MDSM.

https://reviewboard.mozilla.org/r/15227/#review13655

::: dom/media/MediaDecoder.cpp:416
(Diff revision 1)
> +                   "MediaDecoder::mSameOriginMedia (Canonical)")

it seems that the usual mozilla is to always add a trailing , even on the last member, or have it at the front. (I like the later better)

How often does mSameOriginMedia changes ? Should it be set once and for all in the decoder ? If that's the case and it's known when creating the state machine it could be passed as parameter instead.
https://reviewboard.mozilla.org/r/15227/#review13655

> it seems that the usual mozilla is to always add a trailing , even on the last member, or have it at the front. (I like the later better)

Yeah, I also like the later better. But for now I just follow the existing style of MediaDecoder. I will file a new bug to fix the style.

MediaDecoder::UpdateSameOriginStatus() is called by HTMLMediaElement::NotifyDecoderPrincipalChanged() which is called when new data with different principals are downloaded (see MediaCacheStream::NotifyDataReceived). So it is not immutable.
Thanks for the review.
Assignee: nobody → jwwang
https://hg.mozilla.org/mozilla-central/rev/6fb2fb69fe67
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.