1191209 - Turning on/off an IDL file needs a clobber

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

This has happened repeatedly when enabling/disabling Gtk+3 on some platforms, because Gtk+3 have, for instance, nsIApplicationChooser.idl that Gtk+2 builds don't have.

The issue is kind of the same thing that led to the fixup in bug 1114669: https://hg.mozilla.org/mozilla-central/rev/cfdcb37cc953

The problem is that the IDL was previously in the tree, so it's actually older than the xpt target, so the xpt and the headers are not (re)built.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Rebuild XPT files when the list of corresponding IDL files changed

Comment 2

[Johannes Pfrang [:johnp]]

The attached patch 0001-Bug-1191212-Force-a-value-for-PKG_CONFIG-when-buildi.patch doesn't look like the correct one ;)

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8643606 [details] [diff] [review]
Rebuild XPT files when the list of corresponding IDL files changed

Review of attachment 8643606 [details] [diff] [review]:
-----------------------------------------------------------------

Wrong patch for this bug.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Rebuild XPT files when the list of corresponding IDL files changed

doh

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/34a546e5ebe2

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/34a546e5ebe2