1191254 - Empty directories left in /tmp when launching tests

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[jonathan.pigree]

On commit 33b71e7821f20ff6a1a8bb1f801fef4c44e0b447. If I do :
python setup.py tests

It creates directories into /tmp and do not delete them.

Comment 1

[Julien Pagès (:parkouss)]

Good catch, thanks for reporting this!

Comment 2

[jonathan.pigree]

i

Comment 3

[jonathan.pigree]

Okay. I assigned it to myself.

Comment 4

[jonathan.pigree]

The empty dirs come from three test cases:
-> TestBisector
-> TestInboundHandler
-> TestMozRunnerLauncher

Comment 5

[jonathan.pigree]

I continue my investigations.

Comment 6

[jonathan.pigree]

Attachment: PR

Comment 7

[jonathan.pigree]

Okay. I finally have an hang of it. It seems to me that when pytests close, unlike nose it does not call the destructors (__del__). I saw this post which seems to convey my idea "http://stackoverflow.com/questions/15917502/python-file-objects-closing-and-destructors".

I submitted a PR and tell me what you think of it.

Comment 8

[Julien Pagès (:parkouss)]

Comment on attachment 8643762 [details] [review]
PR

Wow, good finding. :) Thanks a lot for the work here!

Hm, it is not good that py.test does not respect that... However reading the link you gave I suspect at first we should have not relied on __del__ at all - for profile or runners.

Comment 9

[Julien Pagès (:parkouss)]

Merged!