1191323 - Lots of l10n spam in device image and emulator builds

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

AFAICT, it's harmless, but it's really annoying because it obscures real problems due to the spamminess of it.

https://treeherder.mozilla.org/logviewer.html#?job_id=1951325&repo=mozilla-central

[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/email/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://email.gaiamobile.org)
[/build_stage/email/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://email.gaiamobile.org)
[/build_stage/email/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://email.gaiamobile.org)
[/build_stage/email/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://email.gaiamobile.org)
[/build_stage/email/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://email.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/conversation/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/views/inbox/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/sms/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://sms.gaiamobile.org)
[/build_stage/email/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://email.gaiamobile.org)
[/build_stage/email/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://email.gaiamobile.org)
[/build_stage/email/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://email.gaiamobile.org)
[/build_stage/email/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://email.gaiamobile.org)
[/build_stage/email/index.html] [l10n] TypeError: ast[pos][attr].$v is undefined (app://email.gaiamobile.org)

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Not sure if it's harmless.

Taking.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Sorry, harmless as in not fatal to the build.

Comment 3

[Francesco Lodolo [:flod]]

Clearing NI since Gandalf is already on it.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: 1191323.patch

So, this is a weird scenario that happens only when l10n .properties file has a hash value without an index. I don't know why our tools don't catch it...

or they do, but they don't do anything about it.

Example from: http://hg.mozilla.org/gaia-l10n/bn-BD/file/1d7e5fe08128/apps/sms/sms.properties#l134

#LOCALIZATION NOTE (fdnErrorBody): the English translation does not need the
# actual number of phone numbers. If your translation needs it, you can still add it
# using the parameter {{ n }}. Also take into account that you could add HTML so be
# careful with the content, it may affect to the whole app.
fdnErrorBody.innerHTML[one]   = FDN (ফিক্সড ডায়ালিং নম্বর) সক্রিয় করা আছে। এসএমএস সেন্টার এবং নিম্নলিখিত প্রাপক আপনার FDN তালিকায় আছে কিনা নিশ্চিত করুন:
fdnErrorBody.innerHTML[two]   = FDN (ফিক্সড ডায়ালিং নম্বর) সক্রিয় করা আছে। এসএমএস সেন্টার এবং নিম্নলিখিত প্রাপক আপনার FDN তালিকায় আছে কিনা নিশ্চিত করুন:
fdnErrorBody.innerHTML[few]   = FDN (ফিক্সড ডায়ালিং নম্বর) সক্রিয় করা আছে। এসএমএস সেন্টার এবং নিম্নলিখিত প্রাপক আপনার FDN তালিকায় আছে কিনা নিশ্চিত করুন:
fdnErrorBody.innerHTML[many]  = FDN (ফিক্সড ডায়ালিং নম্বর) সক্রিয় করা আছে। এসএমএস সেন্টার এবং নিম্নলিখিত প্রাপক আপনার FDN তালিকায় আছে কিনা নিশ্চিত করুন:
fdnErrorBody.innerHTML[other] = FDN (ফিক্সড ডায়ালিং নম্বর) সক্রিয় করা আছে। এসএমএস সেন্টার এবং নিম্নলিখিত প্রাপক আপনার FDN তালিকায় আছে কিনা নিশ্চিত করুন:

This patch fixes how the parser handles this scenario, but it will still not work in production.

Since the file comes from Pootle, I'm CCing Dwayne. And since our compare-locales should yell, CC'ing Pike.

Comment 5

[Axel Hecht [:Pike]]

compare-locales tells, but that doesn't have any impact on anything in practice here. https://l10n.mozilla.org/dashboard/compare?run=510974 shows that fdnErrorBody.innerHTML is missing.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/l20n/l20n.js/commit/ba40882bd075cae8f1e0a788ca3dc558dd631847

Leaving it open waiting for Dwayne's response

Comment 7

[Dwayne Bailey]

Pootle isn't doing anything fancy on the unit.  So this error would occur if:

1) The hashless entity is untranslated - in which case we remove it from output
2) en-US didn't have the entity - in which case we don't pick it up

And it seems 1) is the guilty party here http://mozilla.locamotion.org/bn_BD/firefoxos/translate/apps/sms/sms.properties.po#unit=17540659 (for now).

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Does something need to be uplifted to Gaia in order to see the results of the fix you landed? Still seeing these errors in recent builds.

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Yes. We need to uplift the l20n.js in master.

Stas, do you plan any uplift soon? If not, I can do this.

Comment 10

[Staś Małolepszy :stas]

I filed bug 1193766 to update l20n.js in Gaia master.

Comment 11

[Staś Małolepszy :stas]

The errors should be gone now.  Let me know if there are any other problems!