Refactor editor.js to use 4 spaces for indentation

RESOLVED FIXED

Status

Webtools
Air Mozilla
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: peterbe, Assigned: anubhav.worklinux)

Tracking

Trunk

Firefox Tracking Flags

(firefox42 affected)

Details

(Reporter)

Description

3 years ago
The file https://github.com/mozilla/airmozilla/blob/master/airmozilla/popcorn/static/popcorn/js/editor.js is using 2 spaces for indentation. 

I personally like 2 spaces for JS but I don't like that this one is different from all the others. Consistency is more important.
(Assignee)

Comment 1

3 years ago
hey Peter. i would submit a patch soon for this one.

Comment 3

3 years ago
Commits pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/891be32a20be03d29a674c060a4dfab463c23c73
Fixes Bug 1191415 - Refactor editor.js to use 4 spaces for indentation

https://github.com/mozilla/airmozilla/commit/3828b82eafc5df501e0b32976834adfd77e626ac
Merge pull request #437 from anu7495/my-fix

Fixes Bug 1191415 - Refactor editor.js to use 4 spaces for indentation

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

3 years ago
Hii! could someone assign this bug to me as i cant do it myself so that it shows up in my bugzilla profile as resolved.
need that for college credits.
thanks!

Comment 5

3 years ago
Hi Anubhav,

This bug is already resolved. Thank you for the interest though!
(Assignee)

Comment 6

3 years ago
Hi mike,
i meant that as i was the one who submitted the merged pull request for this bug, i just wanted that if it could show my name in AssignedTo field, so that it shows up in my profile as assigned to me and resolved by me.
thanks!

Updated

3 years ago
Assignee: nobody → anubhav.worklinux
You need to log in before you can comment on or make changes to this bug.