1191416 - Race condition in unittest reviewboard_login verify

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Dan Minor [:dminor]]

I see intermittent failures in the reviewboard_login method of the Unittest class which looks like a race condition with respect to when the browser url is read. Switching to a WebDriverWait fixes things.

Comment 1

[Dan Minor [:dminor]]

Attachment: MozReview Request: testing: fix race condition in reviewboard_login (bug 1191416) r?gps

testing: fix race condition in reviewboard_login (bug 1191416) r?gps

This switches from a direct check of the browser url to a WebDriverWait on the
browser title to verify whether a login was successful. I saw intermittent
failures on my system without the wait which I think were due to a race on
when the browser url was read.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8643807 [details]
MozReview Request: testing: fix race condition in reviewboard_login (bug 1191416) r?gps

https://reviewboard.mozilla.org/r/15151/#review13589

Plausible. Thanks for tracking this down!

Comment 3

[Dan Minor [:dminor]]

Thanks, pushed to: https://hg.mozilla.org/hgcustom/version-control-tools/rev/1fdc85213ddf