Revert SetDispAcquireFence() calling change

RESOLVED FIXED in Firefox 42

Status

()

Core
Graphics
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
+++ This bug was initially created as a clone of Bug #1186031 +++

In Bug 1186031, I changed SetDispAcquireFence() calling place. But it was wrong:( I recognized it in Bug 1186000 Comment 24.
(Assignee)

Updated

2 years ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Comment 1

2 years ago
The following is a copy of Bug 1186000 Comment 24.
-------------------------------------------------

I was confused with FramebufferSurface::setReleaseFenceFd() it is set by hwc. SetDispAcquireFence should be called after OpenGL buffer swap, It calls FramebufferSurface::onFrameAvailable().
(Assignee)

Comment 2

2 years ago
It makes no harm now. But it cause a problem when gonk support non hwc display.
(Assignee)

Comment 3

2 years ago
Created attachment 8643858 [details] [diff] [review]
patch - Revert SetDispAcquireFence() calling change
(Assignee)

Comment 4

2 years ago
Created attachment 8643868 [details] [diff] [review]
patch - Revert SetDispAcquireFence() calling change

Add a comment.
Attachment #8643858 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Attachment #8643868 - Flags: review?(nical.bugzilla)

Updated

2 years ago
Attachment #8643868 - Flags: review?(nical.bugzilla) → review+

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/16166aafd9d5
https://hg.mozilla.org/mozilla-central/rev/16166aafd9d5
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.