1191461 - TelemetryReportingPolicy::get dataSubmissionPolicyNotifiedDate - Invalid date stored

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Every now and then I'm seeing this error in my log on a Nexus 9 (Android 5.1.1):

08-03 12:23:58.464    2738-2783/org.mozilla.fennec_sebastian E/GeckoConsole﹕ [JavaScript Error: "1438597438463	Toolkit.Telemetry	ERROR	TelemetryReportingPolicy::get dataSubmissionPolicyNotifiedDate - Invalid date stored." {file: "resource://gre/modules/Log.jsm" line: 749}]

The clock of the device seems to be correct and is set to update automatically from the network.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: logcat-telemetry-error.txt

This is a logcat dump that contains the error.

Comment 2

[:Margaret Leibovic]

It looks like this could have been from bug 1137355. Georg, what do you think?

Comment 3

[Georg Fritzsche [:gfritzsche]]

Yes, that would be from bug 1137355.

From the code, this might come up if the data choices bar was not accepted yet for that profile:
https://dxr.mozilla.org/mozilla-central/rev/0876695d1abdeb363a780bda8b6cc84f20ba51c9/toolkit/components/telemetry/TelemetryReportingPolicy.jsm#186

Previously, this would just fall back to returning a default date (from Date(0)):
https://dxr.mozilla.org/mozilla-central/rev/0876695d1abdeb363a780bda8b6cc84f20ba51c9/services/datareporting/policy.jsm?offset=0#346

From a quick look, making TelemetryReportingPolicy default to that too should work out fine.

Comment 4

[Georg Fritzsche [:gfritzsche]]

Attachment: Don't report an error if the dataSubmissionPolicyNotifiedTime pref was not set yet

Lets just trivially handle when the pref is not set yet. Margaret, do you mind reviewing?

Comment 5

[:Margaret Leibovic]

Comment on attachment 8648738 [details] [diff] [review]
Don't report an error if the dataSubmissionPolicyNotifiedTime pref was not set yet

Review of attachment 8648738 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/73cc12636227

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/73cc12636227

Comment 8

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8648738 [details] [diff] [review]
Don't report an error if the dataSubmissionPolicyNotifiedTime pref was not set yet

Approval Request Comment
[Feature/regressing bug #]:
Unified Telemetry
[User impact if declined]:
Simple fix that gets rid of a logged error where we shouldnt log any.
This potentially impacts engineering and QA.
[Describe test coverage new/current, TreeHerder]:
Automation coverage.
[Risks and why]:
Low-risk, trivial change and fine on Nightly.
[String/UUID change made/needed]:
None.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8648738 [details] [diff] [review]
Don't report an error if the dataSubmissionPolicyNotifiedTime pref was not set yet

Sure, let's take it.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9fcd5d5d641b