1191510 - Tags with spaces in them are incorrectly split into several tags

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Guy Harris]

Back when the Wireshark bug database was using a version of Bugzilla in which "tags" were named lists of bugs, I created several tags with names containing spaces.  The documentation for this feature in Bugzilla 4.0, at

    https://www.bugzilla.org/docs/4.0/en/html/query.html#individual-buglists

says

    This feature is useful when you want to keep track of several bugs, but for different reasons. Instead of adding yourself to the CC list of all these bugs and mixing all these reasons, you can now store these bugs in separate lists, e.g. "Keep in mind", "Interesting bugs", or "Triage".

which at least suggests that tags can have spaces in them.

Then Wireshark switched to a later version of Bugzilla, with the Shiny New Tagging System.

The "saved searches" corresponding to those tags were preserved, although they didn't show up in the page footer (as they had in the past) until I checked the "Show in Footer" checkbox for them - minor nuisance, although that was a bit of the Principle of Least Surprise being violated (maybe that was a choice offered to the Bugzilla administrator when they upgraded).

I tried to add one of those tags to an additional bug, by typing it in the Tags: field.  Instead, it added each token in the tag name as a separate tag, with commas between them.  Putting the tag name in quotes didn't help - it merely added a " to the beginning of the first token and to the end of the last token.

Tag name completion in the UI still offers the tags with spaces in their names, but if you select one of them from the drop-down list, it ends up adding a bunch of tags, one for each token in the tag name.

Presumably the idea here is that multiple tags can be added, and people might be used to tagging UIs in which you can separate tags with spaces.  If so, then the code to convert old-style tags to new-style tags should probably have converted spaces in tag names to hyphens (but not necessarily done so with spaces in the corresponding saved search name).  Not ideal, as it's not transparent to the user, but it's probably the best that could be done.

Comment 1

[Frédéric Buclin]

Hum, you are right. The conversion code worked correctly. It's only process_bug.cgi which splits tags on spaces too instead of commas only. Trivial fix.

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

Comment 3

[Guy Harris]

So my Perl fu isn't all that strong, but from a quick look at the fix it appears that the change means that you could have something such as

   utf-8 encoding, instant crash

in the tags field, and that would assign the two tags "utf-8 encoding" and "instant crash" to the bug?

Comment 4

[Gervase Markham [:gerv]]

Guy: yes :-) Tags can contain spaces, and so must be comma-separated.

Gerv

Comment 5

[Gervase Markham [:gerv]]

Comment on attachment 8644068 [details] [diff] [review]
patch, v1

Review of attachment 8644068 [details] [diff] [review]:
-----------------------------------------------------------------

Tested, works, r=gerv.

Gerv

Comment 6

[Frédéric Buclin]

To ssh://[e-mail]/bugzilla/bugzilla.git
   ffe87c7..672fe6d  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   568c933..e7a85a4  5.0 -> 5.0