1191514 - AddressSanitizer should suppress log output for intentional crash (" AddressSanitizer: SEGV .../js/src/ctypes/CTypes.cpp:2741 js::ctypes::ConvertToJS(...)")

Status: NEW

(Testing :: General, defect, P3)

Description

[Jonathan French (:jfrench)]

I was going to enter this against as a blocker for bug 1048775, but checking with Ed first before switching to Testing::Mochitest :)

Step to reproduce:
o load https://treeherder.allizom.org/logviewer.html#?job_id=9117571&repo=mozilla-inbound
o click show successful steps

Observed:
In Step 11, these types of lines below are being marked as errors and styled as such by Treeherder

07:08:34 INFO - SUMMARY: AddressSanitizer: SEGV /builds/slave/m-in-l64-asan-0000000000000000/build/src/js/src/ctypes/CTypes.cpp:2741 js::ctypes::ConvertToJS(JSContext*, JS::Handle<JSObject*>, JS::Handle<JSObject*>, void*, bool, bool, JS::MutableHandle<JS::Value>)

Let me know Ed, and I'll switch product and component if applicable :)

Comment 1

[Jonathan French (:jfrench)]

Attachment: mochitestInfoLines

Per screen grab.

Comment 2

[Phil Ringnalda (:philor)]

Among the previous times we've hidden that intentional crash: bug 982600, bug 647213.

Comment 3

[Christian Holler (:decoder)]

I think the subject of this bug is wrong. AddressSanitizer should not suppress anything because it's the wrong place to suppress stuff. If we don't want to count this crash as a bug, we have two options:

1) Don't run the test under ASan (we've done this for other similar tests afaik)

2) Make the tool that parses the info lines aware of this and other intentional crashes (but I assume that doesn't work well because in the log these crashes might be indistinguishable from regular crashes and the risk of flagging something wrongly as intentional is high).