Closed
Bug 1191520
Opened 9 years ago
Closed 9 years ago
Hide search settings footer until it is complete
Categories
(Firefox :: Address Bar, defect, P2)
Firefox
Address Bar
Tracking
()
People
(Reporter: mossop, Assigned: mossop)
References
Details
(Whiteboard: [fxsearch][searchui])
Attachments
(2 files)
3.55 KB,
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
837 bytes,
patch
|
glandium
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Until we have the one-off searches in bug 1180944 it doesn't make a lot of sense to show the search settings footer.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8644007 -
Flags: review?(adw)
Updated•9 years ago
|
Attachment #8644007 -
Flags: review?(adw) → review+
https://hg.mozilla.org/mozilla-central/rev/b5168cc893e8
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Assignee | ||
Comment 4•9 years ago
|
||
Per bug 1194898 this is still showing up in aurora builds
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•9 years ago
|
Rank: 20
Priority: -- → P2
Updated•9 years ago
|
Iteration: --- → 42.3 - Aug 10
Assignee | ||
Comment 5•9 years ago
|
||
[Tracking Requested - why for this release]: This feature should not be on on aurora.
tracking-firefox42:
--- → ?
Assignee | ||
Comment 6•9 years ago
|
||
Ok my previous patch was bad, didn't need the moz.build change.
Attachment #8650210 -
Flags: review?(mh+mozilla)
Updated•9 years ago
|
Attachment #8650210 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 8•9 years ago
|
||
Landed yesterday but didn't get updates for some reason: https://hg.mozilla.org/mozilla-central/rev/4f5fec455502
https://hg.mozilla.org/mozilla-central/rev/4f5fec455502
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8650210 [details] [diff] [review] fix build config Approval Request Comment [Feature/regressing bug #]: Search suggestions [User impact if declined]: This button shouldn't be visible without the additional work on the footer that is coming [Describe test coverage new/current, TreeHerder]: In today's nightly [Risks and why]: Low risk, just hides some UI [String/UUID change made/needed]: None
Attachment #8650210 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Comment 11•9 years ago
|
||
Comment on attachment 8650210 [details] [diff] [review] fix build config Polish patch, taking it.
Attachment #8650210 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•9 years ago
|
Target Milestone: Firefox 42 → Firefox 43
Comment 13•9 years ago
|
||
Environments used: Ubuntu 14.04 x86, Win 10 x64, Mac OS X 10.9.5. Verified using Dev Edition 42.0a2 2015-08-25 that the awesome bar footer with "Change Search Settings" button is no longer shown. However, this is still visible in Nightly 43.0a1 2015-08-25. Is it expected?
Flags: needinfo?(dtownsend)
Comment 14•9 years ago
|
||
yes, the footer should be only visible in Nightly (I'm honestly not sure it's a great idea but, we ended up there)
Updated•9 years ago
|
Flags: needinfo?(dtownsend)
You need to log in
before you can comment on or make changes to this bug.
Description
•