Closed Bug 1191520 Opened 4 years ago Closed 4 years ago
Hide search settings footer until it is complete
Until we have the one-off searches in bug 1180944 it doesn't make a lot of sense to show the search settings footer.
Per bug 1194898 this is still showing up in aurora builds
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
[Tracking Requested - why for this release]: This feature should not be on on aurora.
Ok my previous patch was bad, didn't need the moz.build change.
Attachment #8650210 - Flags: review?(mh+mozilla)
Attachment #8650210 - Flags: review?(mh+mozilla) → review+
Landed yesterday but didn't get updates for some reason: https://hg.mozilla.org/mozilla-central/rev/4f5fec455502
Comment on attachment 8650210 [details] [diff] [review] fix build config Approval Request Comment [Feature/regressing bug #]: Search suggestions [User impact if declined]: This button shouldn't be visible without the additional work on the footer that is coming [Describe test coverage new/current, TreeHerder]: In today's nightly [Risks and why]: Low risk, just hides some UI [String/UUID change made/needed]: None
Attachment #8650210 - Flags: approval-mozilla-aurora?
Comment on attachment 8650210 [details] [diff] [review] fix build config Polish patch, taking it.
Attachment #8650210 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Environments used: Ubuntu 14.04 x86, Win 10 x64, Mac OS X 10.9.5. Verified using Dev Edition 42.0a2 2015-08-25 that the awesome bar footer with "Change Search Settings" button is no longer shown. However, this is still visible in Nightly 43.0a1 2015-08-25. Is it expected?
yes, the footer should be only visible in Nightly (I'm honestly not sure it's a great idea but, we ended up there)
You need to log in before you can comment on or make changes to this bug.