Closed Bug 1191527 Opened 5 years ago Closed 5 years ago

Fix the ConvertPlanarYCbCr path in BlitImageToFramebuffer

Categories

(Core :: Graphics, defect)

29 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The pixel shader is currently broken (missing a ';'), and we're using GL_LUMINANCE which triggers really bad padding paths in ANGLE.

Fixing this and using GL_ALPHA8 improves performance considerably.
f+, LUMINANCE should not be used.

Alpha8 is technically deprecated as well, so we should plan on using R8 on GLES3 and GL core profiles.
Attached patch fix-ycbcrSplinter Review
Attachment #8643984 - Flags: review?(jgilbert)
Attachment #8643984 - Flags: review?(jgilbert) → review+
I do believe A8 textures may still be being expanded to RGBA8 inside ANGLE though. It'd be nice to double-check.
https://hg.mozilla.org/mozilla-central/rev/d5ce8d41ffbf
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.