Closed Bug 1191527 Opened 9 years ago Closed 9 years ago

Fix the ConvertPlanarYCbCr path in BlitImageToFramebuffer

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Version:
29 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

fix-ycbcr
4.44 KB, patch
jgilbert
: review+
Details | Diff | Splinter Review 
The pixel shader is currently broken (missing a ';'), and we're using GL_LUMINANCE which triggers really bad padding paths in ANGLE.

Fixing this and using GL_ALPHA8 improves performance considerably.
f+, LUMINANCE should not be used.

Alpha8 is technically deprecated as well, so we should plan on using R8 on GLES3 and GL core profiles.
Attached patch fix-ycbcr — — Splinter Review 

        Attachment #8643984 -
        Flags: review?(jgilbert)

        Attachment #8643984 -
        Flags: review?(jgilbert) → review+

    
    

    
  
I do believe A8 textures may still be being expanded to RGBA8 inside ANGLE though. It'd be nice to double-check.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/d5ce8d41ffbf
Status: NEW → RESOLVED
Closed: 9 years ago

          status-firefox42:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: