1191534 - Implement GLBlitHelper::BlitImageToFramebuffer for MacIOSurfaceImage

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Matt Woodrow (:mattwoodrow)]

When we're using hardware decoding on OSX we can directly copy the video frames into WebGL without readback, we should do this.

Comment 1

[Daosheng Mu[:daoshengmu]]

I also follow this bug. I find that depends on video format. On this demo, http://threejs.org/examples/#vr_video, it will enable BlitImageToFramebuffer because its image type is PLANAR_YCBCR. For other demos, like this one, http://mozvr.github.io/loops/20150727_cubes/index.html, it uses MacIOSurfaceImage. Anyway, I think probably I can help contribute to this bug.

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Implement BlitImageToFramebuffer for IOSurface

Creating and deleting the textures each time probably isn't ideal, but we don't have a great way of unbinding the IOSurface without doing so.

Leaving it bound will hold a reference internally and prevent VideoToolkit from recycling the surface (until we draw another frame).

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8646509 [details] [diff] [review]
Implement BlitImageToFramebuffer for IOSurface

Review of attachment 8646509 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLBlitHelper.h
@@ +157,5 @@
>      bool BlitSurfaceTextureImage(layers::SurfaceTextureImage* stImage);
>      bool BlitEGLImageImage(layers::EGLImageImage* eglImage);
>  #endif
> +#ifdef XP_MACOSX
> +    bool BlitMacIOSurfaceImage(layers::MacIOSurfaceImage* ioImage);

Avoid ifdefing decls. Instead ifdef the definitions, MOZ_CRASHing when ifndef.

This allows calling code to not become polluted with ifdefs.

I suppose this is 'protected' anyway, so it doesn't matter so much.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c6c91bdf11c0

Comment 5

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/88b010225dee

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8faa9fe21d15

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8faa9fe21d15