1191537 - Two permalinks in navbox

Status: RESOLVED FIXED

(Webtools Graveyard :: DXR, defect)

Description

[Jesse Ruderman]

Attachment: Screenshot

https://dxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxPlatform.cpp has two permalinks in the navbox. They seem to be the same.

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/3ad80cbf4d7fc5e531f935e6f225f28526b52058
Keep core plugin from multiply contributing. Fixes bug 1191537.

Config would call all_plugins(), which includes core, and then TreeConfig would add core again.

core is no longer part of Config's enabled_plugins. The only places core comes from now are a TreeConfig's enabled_plugins attr and plugins_named(), which is always fed a frozen list of names from the catalog. Introduce all_plugins_but_core() and core_plugin() for DRY.

Switch the order of some blocks in dxr.plugins to avoid multiple returns.

Also, make skimmers run in the order that plugins are specified in the config file.

Comment 3

[Erik Rose [:erik][:erikrose]]

The doubles should go away the next time the trees are reindexed.

Comment 4

[[github robot]]

Commit pushed to optimize-refs at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/3ad80cbf4d7fc5e531f935e6f225f28526b52058
Keep core plugin from multiply contributing. Fixes bug 1191537.

Comment 5

[Erik Rose [:erik][:erikrose]]

This is back now. :-(

Comment 6

[Tom Klein]

I don't think I've ever seen this, closing as fixed.