Closed Bug 1191583 Opened 4 years ago Closed 4 years ago

Add telemetry probes for touch usage

Categories

(Firefox :: General, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 43
Tracking Status
firefox41 - ---
firefox42 + fixed
firefox43 --- fixed

People

(Reporter: Dolske, Assigned: jaws)

References

Details

User Story

User Story

As a product manager I would like to know how many users have the capability for touch screens and how often they interact with Firefox through touch such that I can help prioritize additional work in the future around Firefox touch screen interactions.

Acceptance Criteria

Metrics that capture if a touch display is supported
Metrics that capture how many touch events and what types occur per session

Attachments

(2 files)

Over in bug 1181500 we're adding probes for Windows 10 Tablet Mode usage. I think it would also be useful to have separate, simple probes for (1) does the user's display support touch and (2) has the user actually touched their display.

We don't really know just how prevalent touch hardware is, or how much users are making use of it. It also might help provide an effective upper-bound on _potential_ Tablet Mode usage.
Jimm notes in bug 1158152 comment 7:

"We have telemetry - TOUCH_ENABLED_DEVICE. Currently about 12% of users running windows 8 and up have a touch capable device in the release channel."

Still seems like it would be useful to know how many of those users are actually using it.
Updating summary given last comment. Also this should probably include touch gestures (either as an all-in-one or as a separate probe).
Summary: Add telemetry probes for touch capability / usage → Add telemetry probes for touch usage
Adding in the user story.  

We're interested in knowing if users are using touch screens to interact with Firefox.  Questions to be answered are: "Are users using the touch screen to touch the back button?" and "Are users using their touch screen to swipe back the page?".  With these questions answered we could attempt to prioritize making Firefox more touch friendly in context menus, toolbars, and swipe controls.
User Story: (updated)
As for adding a probe that is used when a touch event occurs, I'm not sure what we can use to get that data right now. Both bug 960316 and bug 1166347 aren't fixed (Enable Pointer Events), and Touch Events were disabled in Firefox 24 (bug 888304).

Matt, do you know of a way to track if touch is used outside of those two APIs?
Flags: needinfo?(mbrubeck)
Assignee: nobody → jaws
Status: NEW → ASSIGNED
[Tracking Requested - why for this release]: Another bug on the 41 list we might try and get in. Nominating for tracker per Ritu's request.
Unassigning until we find a way to do this.

Jim, do you have any ideas to add to comment #4?
Assignee: jaws → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(jmathies)
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6)
> Unassigning until we find a way to do this.
> 
> Jim, do you have any ideas to add to comment #4?

Yeah check out WinUtils::GetIsMouseFromTouch, you could call this on a mouse down event and update a probe.
Flags: needinfo?(jmathies)
Attached patch PatchSplinter Review
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8657315 - Flags: review?(jmathies)
Attachment #8657315 - Flags: feedback?(ally)
Attachment #8657315 - Flags: review?(jmathies) → review+
Comment on attachment 8657315 [details] [diff] [review]
Patch

Review of attachment 8657315 [details] [diff] [review]:
-----------------------------------------------------------------

p=ally with nits.

::: toolkit/components/telemetry/Histograms.json
@@ +4240,5 @@
>      "description": "Windows 10+ only: The number of times tablet-mode is used during a session"
>    },
> +  "FX_TOUCH_USED": {
> +    "expires_in_version": "46",
> +    "kind": "boolean",

I don't think you actually want a boolean here, since all you're ever recording is "true". Why not use a counter?

@@ +4241,5 @@
>    },
> +  "FX_TOUCH_USED": {
> +    "expires_in_version": "46",
> +    "kind": "boolean",
> +    "description": "True if a touch event was encountered"

please add that this is a windows only probe to the description.
Attachment #8657315 - Flags: feedback?(ally) → review+
url:        https://hg.mozilla.org/integration/fx-team/rev/9c86524b460ef9704eeef66cd8f0f964d2ad9777
changeset:  9c86524b460ef9704eeef66cd8f0f964d2ad9777
user:       Jared Wein <jwein@mozilla.com>
date:       Tue Sep 08 23:14:56 2015 -0400
description:
Bug 1191583 - Add telemetry probes for touch usage. r=jimm p=ally
https://hg.mozilla.org/mozilla-central/rev/9c86524b460e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Tracked for 42, it is too late to take this in 41.
Approval Request Comment
[Feature/regressing bug #]: telemetry probes for windows 10/touch
[User impact if declined]: less information to make decisions about what is necessary to work on
[Describe test coverage new/current, TreeHerder]: manual testing via about:telemetry
[Risks and why]: none
[String/UUID change made/needed]: none
Attachment #8658849 - Flags: approval-mozilla-aurora?
Comment on attachment 8658849 [details] [diff] [review]
Patch for Aurora42

If this can help you, taking it.
Attachment #8658849 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.