1191587 - Some mathematical expressions in location bar fail to provide search suggestions

Status: RESOLVED WORKSFORME

(Firefox :: Search, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

STR:
Set Google as the default search engine
In the search box, type "100 + 3" with no quotes
See that the suggestion offered is "103".
In the location bar, type "100 + 33" with no quotes

ER:
The location bar should have "103" as a suggestion.

AR:
The location bar doesn't have any suggestions. If the query is "100+ 33" then the location bar will show "103" as a suggestion.

This may have been regressed by bug 1184960 but the patch in that bug doesn't look like it affects additions. Marco, do you know what may have caused this?

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

(In comment #0, s/33/3/)

Comment 2

[Marco Bonardo [:mak]]

should be debugged, I have no idea off-hand. Did you confirm the problem is bug 1184960? why didn't we have a test for this if it was important?

Comment 3

[Marco Bonardo [:mak]]

I wonder if we are removing the + cause it's the restrict tags char OR if _prohibitSearchSuggestionsFor is throwing.

Comment 4

[Mark Banner (:standard8)]

Jared, on latest nightly when using Google I see "= 103" and using DuckDuckGo, I see "100+3=103".

So I guess we can close this as WFM now?

Comment 5

[Marco Bonardo [:mak]]

we stopped removing restriction chars from the middle, it may have fixed this.