Closed Bug 1191603 Opened 9 years ago Closed 9 years ago

Don't spawn additional validation tasks for a file if one is already running

Categories

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Product:
addons.mozilla.org Graveyard
Component:
Add-on Validation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2015-08

People

(Reporter: kmag, Assigned: kmag)

References

Details

(Whiteboard: [qa-]) 

We currently spawn a validation task for a file when uncached validations are requested, even if a task is already running. This tends to be a problem when reviewers open the file viewer and the validation viewer at the same time, since they both request the same validation URL.

We should spawn only one job, and cache the task ID for future requests.
Blocks: 1191604
Commit pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/4b87b23fee35bc37bd4627a6e07e874b996c004e
Bug 1191603: Run the validator only once per object, and return a cached AsyncResult if a job is already running.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2015-08
Can you please add some STRs to this bug or mark it as [qa-] ?
I can't think of a good way to verify this. I think the unit tests will have to be enough.
Whiteboard: [qa-]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.