1191632 - Perfherder compare no longer links to resultset page

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

https://treeherder.allizom.org/perf.html#/comparesubtest?originalProject=mozilla-inbound&originalRevision=4d0818791d07&newProject=mozilla-inbound&newRevision=5e130ad70aa7&originalSignature=72f4651f24362c87efb15d5f4113b9ca194d8e3f&newSignature=72f4651f24362c87efb15d5f4113b9ca194d8e3f

The 'new' link shows "5e130ad70aa7", however the URL points to "https://hg.mozilla.org/integration/mozilla-inbound/rev/4d0818791d07", which is the same as the 'base' link.

Comment 1

[Ed Morley [:emorley]]

Thank you for filing :-)

Comment 2

[Ed Morley [:emorley]]

Attachment: Use correct 'new' revision for hg.m.o link generation

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8644226 [details] [review]
Use correct 'new' revision for hg.m.o link generation

We should actually be linking to the treeherder resultset page for ease of retriggering: this was done in bug 1185155 but apparently was lost here. I'll fix that today, but we might as well put in this interim fix meanwhile. Thanks for the fast response!

Comment 4

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ed52bdb062b40d2353c2bbb8e49f37bda490784b
Bug 1191632 - Use correct 'new' revision for hg.m.o link generation

Previously the link target was pointing at a different revision to that
displayed in the link text.

https://github.com/mozilla/treeherder/commit/ba82ca5895f1f08780163359c83a8b38a8f54a11
Merge pull request #837 from mozilla/correct-revision-describe-link

Bug 1191632 - Use correct 'new' revision for hg.m.o link generation

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/534a4247ba0b329d5a787f87fba64ba58c220dd7
Bug 1191632 - Link to resultset from comparison view again

Comment 6

[William Lachance (:wlach)]

Fixed problem properly with a followup (essentially just a revert, so no new review needed IMO).