Closed Bug 119164 Opened 23 years ago Closed 23 years ago

remove obsolete xul elmts and attrs from Composer xul

Categories

(SeaMonkey :: Composer, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glazou, Assigned: glazou)

Details

Attachments

(1 file, 1 obsolete file)

Extract from bug 77705 : ------- Additional Comment #114 From Blake Ross 2002-01-09 10:48 ------- You may want to have a xul person review your xul changes in the future. Your patch added some <text class="label"/>, and reverted some <label/> tags (which are correct) to <text/> as well. The text tag is deprecated, in fact it shouldn't even be working anymore. This needs to be fixed. Do you want to do that here, or as part of a separate bug? Also, you don't need the prefattribute and preftype attributes on a <checkbox/>. ------- Additional Comment #115 From Charles Manske 2002-01-09 11:22 ------- I reviewed the XUL a few weeks ago, but I'll take responsibility for not telling Daniel about using <label> instead of <text>
Attached patch patch #1.0 (obsolete) — Splinter Review
patch for EdTableProps.xul and pref-composer.xul. Charley and Blake, can you please review ? Thx.
What about the second comment by Blake: > Also, you don't need the prefattribute and preftype attributes on a <checkbox/>
Status: NEW → ASSIGNED
Attached patch patch v2.0Splinter Review
patch v2.0
Attachment #64278 - Attachment is obsolete: true
Comment on attachment 64280 [details] [diff] [review] patch v2.0 sr=blake
Attachment #64280 - Flags: superreview+
Sorry, I didn't mean to take a hit at Charley in my comment. He's certainly as good a xul person as any (I thought jfrancis reviewed it all).
Comment on attachment 64280 [details] [diff] [review] patch v2.0 r=peterv
Attachment #64280 - Flags: review+
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Daniel, please verify....thanks.
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: