119164 - remove obsolete xul elmts and attrs from Composer xul

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Daniel Glazman (:glazou) (NOT MONITORING BMO ANY MORE)]

Extract from bug 77705 :

------- Additional Comment #114 From Blake Ross 2002-01-09 10:48 -------

You may want to have a xul person review your xul changes in the future. Your 
patch added some <text class="label"/>, and reverted some <label/> tags (which 
are correct) to <text/> as well.  The text tag is deprecated, in fact it 
shouldn't even be working anymore. This needs to be fixed. Do you want to do 
that here, or as part of a separate bug?

Also, you don't need the prefattribute and preftype attributes on a <checkbox/>.



------- Additional Comment #115 From Charles Manske 2002-01-09 11:22 -------

I reviewed the XUL a few weeks ago, but I'll take responsibility for not telling
Daniel about using <label> instead of <text>

Comment 1

[Daniel Glazman (:glazou) (NOT MONITORING BMO ANY MORE)]

Attachment: patch #1.0

patch for EdTableProps.xul and pref-composer.xul.
Charley and Blake, can you please review ? Thx.

Comment 2

[Daniel Bratell]

What about the second comment by Blake:

> Also, you don't need the prefattribute and preftype attributes on a <checkbox/>

Comment 3

[Daniel Glazman (:glazou) (NOT MONITORING BMO ANY MORE)]

Attachment: patch v2.0

patch v2.0

Comment 4

[Blake Ross]

Comment on attachment 64280 [details] [diff] [review]
patch v2.0

sr=blake

Comment 5

[Blake Ross]

Sorry, I didn't mean to take a hit at Charley in my comment.  He's certainly as
good a xul person as any (I thought jfrancis reviewed it all).

Comment 6

[Peter Van der Beken [:peterv]]

Comment on attachment 64280 [details] [diff] [review]
patch v2.0

r=peterv

Comment 7

[Daniel Glazman (:glazou) (NOT MONITORING BMO ANY MORE)]

checked in

Comment 8

[sujay]

Daniel, please verify....thanks.