Closed Bug 1191688 Opened 5 years ago Closed 5 years ago

Add -nologo option to rc.exe

Categories

(Firefox Build System :: General, defect)

Unspecified
Windows
defect
Not set
normal

Tracking

(firefox42 affected, firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox42 --- affected
firefox43 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

Now, when compiling resource file by rc.exe on Windows, outputted log shows the following version information.

16:46.11 Creating Resource file: module.res
16:46.16 Microsoft (R) Windows (R) Resource Compiler Version 10.0.10011.0
16:46.16
16:46.16 Copyright (C) Microsoft Corporation.  All rights reserved.
16:46.16

We already use -nologo option for C/C++ compiler etc, but rc.exe isn't.  I cannot find why nologo option isn't set on rc.exe.

But I think we should add it to rc.exe (RCFLAGS)
We already use -logo option for cl.exe and link.exe.  But we don't use it for rc.exe.  I think that we should reduce output log size.

I looked for reason why we don't use, but I cannot find it.
Assignee: nobody → m_kato
Attachment #8648547 - Flags: review?(ted)
Attachment #8648547 - Attachment is patch: true
Comment on attachment 8648547 [details] [diff] [review]
Add -nologo option to rc.exe

Review of attachment 8648547 [details] [diff] [review]:
-----------------------------------------------------------------

I'm sure there's no reason this hasn't been used except that nobody thought to do it!
Attachment #8648547 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/03cc3e7e3531
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.