1191694 - Some PDFs on beta.companieshouse.gov.uk are blank

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, defect, P2)

Description

[Jonathan Watt [:jwatt]]

Some of the PDFs on the UK government's beta.companieshouse.gov.uk site aren't properly working in Firefox (they works in Chrome). For example, try viewing any of the top three PDFs here:

https://beta.companieshouse.gov.uk/company/01169327/filing-history

Comment 1

[Brendan Dahl [:bdahl]]

The PDF appears to be corrupted. It opens fine in acrobat but then asks to save on closing which means it has also found it to be corrupt.

Error: Invalid XRef stream header pdf.worker.js:251:5
XRef_readXRef@resource://pdf.js/build/pdf.worker.js:3738:13
XRef_parse@resource://pdf.js/build/pdf.worker.js:3333:23
PDFDocument_setup@resource://pdf.js/build/pdf.worker.js:2501:7
PDFDocument_parse@resource://pdf.js/build/pdf.worker.js:2382:7
ensureHelper@resource://pdf.js/build/pdf.worker.js:2000:22
NetworkPdfManager_ensure/<@resource://pdf.js/build/pdf.worker.js:2014:7
NetworkPdfManager_ensure@resource://pdf.js/build/pdf.worker.js:1994:1
BasePdfManager_ensureDoc@resource://pdf.js/build/pdf.worker.js:1861:14
loadDocument/</<@resource://pdf.js/build/pdf.worker.js:33568:11
promise callback*loadDocument/<@resource://pdf.js/build/pdf.worker.js:33567:1
promise callback*loadDocument@resource://pdf.js/build/pdf.worker.js:33566:1
promise callback*wphSetupDoc@resource://pdf.js/build/pdf.worker.js:33786:1
messageHandlerComObjOnMessage@resource://pdf.js/build/pdf.worker.js:1225:9
EventHandlerNonNull*MessageHandler@resource://pdf.js/build/pdf.worker.js:1191:3
pdfjsWrapper@resource://pdf.js/build/pdf.worker.js:34011:17
@resource://pdf.js/build/pdf.worker.js:28:1
 pdf.worker.js:252:1
Warning: Unsupported feature "unknown" pdf.worker.js:243:5
Warning: Unsupported feature "unknown" pdf.js:243:5
Warning: Indexing all PDF objects

Comment 2

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Adding a tracking flag for FF41.

Comment 3

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Fixed in FF41 given that PDF.js changes landed in bug 1198724.

Comment 4

[Cornel Ionce [:noni] [Hubs QA]]

The PDFs are still not displayed on Firefox 41 beta 9 (build ID: 20150910171927), across platform.
The console throws the same error twice: http://i.imgur.com/SS3nAjn.png (not sure why the PDF.js version is still 1.1.215)

This is working fine on latest Nightly and Aurora builds and the changes landed in bug 1198724 should also be in Beta. Any ideas of what could have happened here?

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Redirecting the question to Yury who helped cherry pick some of the PDF.js uplifts to 41.

Comment 6

[Yury Delendik (:yury)]

Can you provide STR for comment 4? It WFM in https://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/41.0-candidates/build3/ for the first document at https://beta.companieshouse.gov.uk/company/01169327/filing-history.

Version of PDF.js in the mozilla-central with uplifted patches might not change.

Also, notice that those PDFs are corrupted -- you will see error message in the console. The best we can do is to try recovering the document and showing what we fixed.

Comment 7

[Cornel Ionce [:noni] [Hubs QA]]

It also WFM for the first document but the second and third document I see those console errors and the PDFs are just partially displayed (with the first pages blank) using 41.0RC build 3.

I've also tested now using 42.0b1, latest Aurora and latest Nightly builds - those pages are correctly displayed and the errors are not thrown in the console, so it seems that Firefox 41 (and lower, of course) is the only one that does not render them.

Comment 8

[Yury Delendik (:yury)]

The patches from bug 1198724 were uplifted correctly. It probably need additional patches that landed in 42 (e.g. https://github.com/mozilla/pdf.js/pull/6197). I don't think we want to uplift additional patches.

Comment 9

[Cornel Ionce [:noni] [Hubs QA]]

Based on comment 8, I'm removing the qe-verify tracking flag as there is nothing else we can help here with.
If the patches will be uplifted please re-add the flag.
Thanks!