Do not manually handle keyboard overlapping with WKWebView

RESOLVED FIXED

Status

()

Firefox for iOS
Firefox Accounts
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: fluffyemily, Assigned: st3fan, Mentored)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios+)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
On iPhone 5S or lower

STR:
On Sign in where only a password is requested
tap inside password box to display the keyboard
attempt to scroll page up to reveal password textfield

Expected: text field is either automatically displayed above keyboard or is scrollable to above keyboard

Actual:

text field stubbornly refuses to come out from behind keyboard
Assignee: nobody → sarentz
Status: NEW → ASSIGNED
tracking-fxios: ? → +
Summary: Unable to scroll to Password logging in to firefox account on iPhone 5S → Unable to scroll to Password field logging in to Firefox Accounts on iPhone 5S
(Assignee)

Updated

3 years ago
Summary: Unable to scroll to Password field logging in to Firefox Accounts on iPhone 5S → Do not manually handle keyboard overlapping with WKWebView
(Assignee)

Comment 1

3 years ago
The WKWebView already listens to keyboard events and will adjust its content properly when the keyboard overlaps.
(Assignee)

Comment 2

3 years ago
Created attachment 8644546 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/877

This patch removes all keyboard handling code and lets the WKWebView handle it.
Attachment #8644546 - Flags: review?(etoop)
(Assignee)

Comment 3

3 years ago
Tested on 4S, 6 and iPad in simulator and on real device.
(Reporter)

Comment 4

3 years ago
Comment on attachment 8644546 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/877

Just a short comment about a possible code cleanup.
Attachment #8644546 - Flags: review?(etoop) → review+
(Assignee)

Comment 5

3 years ago
https://github.com/mozilla/firefox-ios/commit/35302d2811d14aa673cd74c93f1c31ed2dfb45d2
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.