Closed Bug 1191767 Opened 9 years ago Closed 9 years ago

Do not manually handle keyboard overlapping with WKWebView

Categories

(Firefox for iOS :: Firefox Accounts, defect)

Product:
Firefox for iOS
Component:
Firefox Accounts
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios + ---

People

(Reporter: fluffyemily, Assigned: st3fan, Mentored)

Details

Attachments

(1 file)

PR: https://github.com/mozilla/firefox-ios/pull/877
47 bytes, text/x-github-pull-request
fluffyemily
: review+
Details | Review 
On iPhone 5S or lower

STR:
On Sign in where only a password is requested
tap inside password box to display the keyboard
attempt to scroll page up to reveal password textfield

Expected: text field is either automatically displayed above keyboard or is scrollable to above keyboard

Actual:

text field stubbornly refuses to come out from behind keyboard
Assignee: nobody → sarentz
Status: NEW → ASSIGNED
tracking-fxios: ? → +
Summary: Unable to scroll to Password logging in to firefox account on iPhone 5S → Unable to scroll to Password field logging in to Firefox Accounts on iPhone 5S
Summary: Unable to scroll to Password field logging in to Firefox Accounts on iPhone 5S → Do not manually handle keyboard overlapping with WKWebView
The WKWebView already listens to keyboard events and will adjust its content properly when the keyboard overlaps.
This patch removes all keyboard handling code and lets the WKWebView handle it.
Attachment #8644546 - Flags: review?(etoop)
Tested on 4S, 6 and iPad in simulator and on real device.
Comment on attachment 8644546 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/877

Just a short comment about a possible code cleanup.
Attachment #8644546 - Flags: review?(etoop) → review+
https://github.com/mozilla/firefox-ios/commit/35302d2811d14aa673cd74c93f1c31ed2dfb45d2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: