1191787 - PNG crushing does not work with S3

Status: RESOLVED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P1)

Description

[Mathieu Pillard [:mat]]

When zamboni is configured to use S3 as its storage class, png crushing is not applied correctly to icons and previews.

It depends on the pngcrush binary, so we probably need to copy the file locally, run pngcrush, then move it back to the remote storage.

We also need to investigate why tests were passing even when configured to use S3 despite this bug.

Comment 1

[Allen Short [:ashort]]

https://github.com/mozilla/zamboni/commit/18b4e61cdfd3a2cce70035ff68b10f53d11ce4b7
https://github.com/mozilla/zamboni/commit/959ebb4cc2f8736df154c6296d85afc240d3c4ec

Comment 2

[Mathieu Pillard [:mat]]

I haven't looked at the logs yet but it seems it's still not working.

I made the following app: https://marketplace-s3dev.allizom.org/developers/app/test-app-shark/edit

The thumb that was generated is:
https://marketplace-s3dev-public.s3.amazonaws.com/data/marketplace-s3dev.allizom.org/shared_storage/uploads/previews/thumbs/0/392.png?modified=111111111111111111111111111111

(You can replace the querystring to make sure you have the most recent version)

That image is 21K. When I run the same pngcrush command the task is using locally on this image, I end up with a 17K image.

Comment 3

[Allen Short [:ashort]]

Previews never used PNG crushing so this is expected.