119179 - support for xlC5, change some ifdefs

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Jim Dunn]

When xlC 3.6.4 was the only compiler we were using, we added
many ifdef AIX lines to pieces of code.  xlC5 fixes many of these
so I want to change the ifdef AIX lines to if AIX_XLC_364
(NOTE: this means xlC 3.6.4 builds will have to set this define
in their CFLAGS & CXXFLAGS - I will update http://www.mozilla.org/unix/aix.html)

Comment 1

[Jim Dunn]

Attachment: list of changes

List of files/ifdefs to change. 
NOTE: I am also adding ifdefs for nsKeyboardUtils.cpp which
fix build issues with the Explicit keyword that causes problems
on most unix systems.  this has already been checked in for Tru64
and now I am doing it for Hpux & aix (see revision 1.5 for info)

Comment 2

[Jim Dunn]

adding dbaron and dougt just so they are in the loop because I am 
touching xpcom files as well as mike kaply since these ifdefs also
contain OS/2 pieces (mike I aint messin wid ya, just lettin u know.)

Comment 3

[hacker formerly known as [e-mail]]

If setting that define is going to be required for all builds using that
compiler, we should check the compiler version in configure.in and set the
define there.  Is there anyway to get the compiler version from the compiler
(ie, xlc_r -v )?

Comment 4

[Jim Dunn]

Attachment: configure.in patch - to check compiler version

Not a totally clean patch but it is the best
I could come up with.  Since there are basically
2 xlC compilers available 3.6.x & 5.x, 
5.x supports reinterpret casts, 3.6 doesn't.
So if we are on aix, and not using gcc AND we don't
support reinterpret cast... then it is safe to assume
that it is xlC 3.6.4

cls, good?

Comment 5

[Jim Dunn]

So now that 0.9.8 has been branched, can I get an
r= for both of these patches for the trunk?

For certain areas change the ifdef AIX to ifdef AIX_XLC_364
and then to add the setting of AIX_XLC_364 in configure.in?

Comment 6

[hacker formerly known as [e-mail]]

Comment on attachment 65035 [details] [diff] [review]
configure.in patch - to check compiler version

r=cls

Comment 7

[Jim Dunn]

fix checked in