Closed Bug 1191819 Opened 4 years ago Closed 4 years ago

remove some CXXFLAGS usage from updater's Makefile.in(s)

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox42 fixed)

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(2 files)

No description provided.
We appear to be inconsistent about which CFLAGS variables get
substituted as lists (most things relating to widget libraries, for
instance) and which are just raw strings (most everything else).  This
patch is a first step towards making everything a list, which makes the
next patch much easier to write.  The other variables can be converted
as a followup bug.
Attachment #8644336 - Flags: review?(mshal)
Attachment #8644336 - Flags: review?(mshal) → review+
Comment on attachment 8644337 [details] [diff] [review]
part 2 - move updater's CXXFLAGS munging to moz.build

Hmm, I'm somewhat surprised we don't have HOST_CXXFLAGS in moz.build yet to get other-licenses/bsdiff/Makefile.in as well.
Attachment #8644337 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/3e4f8b308d43
https://hg.mozilla.org/mozilla-central/rev/e9cce42a5e67
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
I believe this patch is preventing me from building fx-team.


0:41.62 The error occurred while processing the following file:
 0:41.62 
 0:41.62     /Users/jsantell/Dev/gecko-dev/toolkit/mozapps/update/updater/moz.build
 0:41.62 
 0:41.63 The error was triggered on line 15 of this file:
 0:41.63 
 0:41.63     CXXFLAGS += CONFIG['MOZ_BZ2_CFLAGS']
 0:41.63 
 0:41.63 An error was encountered as part of executing the file itself. The error appears to be the fault of the script.
 0:41.63 
 0:41.63 The error as reported by Python is:
 0:41.63 
 0:41.63     ['ValueError: Only lists can be appended to lists.\n']
 
and

0:38.54 ==============================
 0:38.54 ERROR PROCESSING MOZBUILD FILE
 0:38.54 ==============================
 0:38.54 
 0:38.54 The error occurred while processing the following file:
 0:38.54 
 0:38.54     /Users/jsantell/Dev/gecko-dev/toolkit/mozapps/update/updater/updater-xpcshell/moz.build
 0:38.54 
 0:38.54 The error was triggered on line 15 of this file:
 0:38.54 
 0:38.54     CXXFLAGS += CONFIG['MOZ_BZ2_CFLAGS']
 0:38.54 
 0:38.54 An error was encountered as part of executing the file itself. The error appears to be the fault of the script.
 0:38.54 
 0:38.54 The error as reported by Python is:
 0:38.54 
 0:38.54     ['ValueError: Only lists can be appended to lists.\n']
 0:38.54
Removing the two CXXFLAGS += CONFIG['MOZ_BZ2_CFLAGS'] lines from the two moz.build files lets me continue building
What does:

grep MOZ_BZ2_CFLAGS $srcdir/configure.in

say for you?
Flags: needinfo?(jsantell)
This is what I get:

$ grep MOZ_BZ2_CFLAGS configure.in 
    [MOZ_NATIVE_BZ2= MOZ_BZ2_CFLAGS= MOZ_BZ2_LIBS=])
    MOZ_BZ2_CFLAGS="-I${BZ2_DIR}/include"
AC_SUBST_LIST(MOZ_BZ2_CFLAGS)
Flags: needinfo?(jsantell)
OK, then I guess you need to reconfigure...it's not clear to me why mach *isn't* doing that first before rebuilding the world, but that would be worth filing a separate bug on.
Interesting -- thanks!
Jordan, what were you running that led to that error? mach build should have rerun configure on its own.
`mach clobber && mach build`
Also doing incremental builds not touching mozapps, like `mach build toolkit/devtools`
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #13)
> `mach clobber && mach build`

That is simply not possible to have resulted in comment 6

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #14)
> Also doing incremental builds not touching mozapps, like `mach build
> toolkit/devtools`

That, on the other hand, yes.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.