Closed Bug 1191849 Opened 9 years ago Closed 9 years ago

Add --locale parameter to select phone's locale in gaia ui test

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: njpark, Assigned: njpark)

Details

Attachments

(1 file)

[gaia] npark-mozilla:1191849 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
martijn.martijn
: review+
jlorenzo
: review+
Details | Review 
Add a command line parameter to set the phone's locale for each run of gaia ui test.
Assignee: nobody → npark
Component: Marionette → Gaia::UI Tests
Product: Testing → Firefox OS
Comment on attachment 8645158 [details] [review]
[gaia] npark-mozilla:1191849 > mozilla-b2g:master

Moved --locale to gaiatest, so now it checks when initially loading the setting
Attachment #8645158 - Flags: review?(martijn.martijn)
Attachment #8645158 - Flags: review?(jlorenzo)
Comment on attachment 8645158 [details] [review]
[gaia] npark-mozilla:1191849 > mozilla-b2g:master

Thanks!
Attachment #8645158 - Flags: review?(martijn.martijn) → review+
Comment on attachment 8645158 [details] [review]
[gaia] npark-mozilla:1191849 > mozilla-b2g:master

That's a good start of patch.

I'm not sure on how we could put the value in testvars.json. To do so, we can add the value in the testvars_template file. The behavior when you don't set any language is a bit unclear.
Attachment #8645158 - Flags: review?(jlorenzo)
Comment on attachment 8645158 [details] [review]
[gaia] npark-mozilla:1191849 > mozilla-b2g:master

PR updated
Attachment #8645158 - Flags: review?(jlorenzo)
Comment on attachment 8645158 [details] [review]
[gaia] npark-mozilla:1191849 > mozilla-b2g:master

LGTM!
Attachment #8645158 - Flags: review?(jlorenzo) → review+
https://github.com/mozilla-b2g/gaia/commit/243582cc1366299f2e02d3eff08a6be6d9d103d9

Merged
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: