1191858 - [LockScreen] Fix |transfer| test in state manager unit tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

Julien has found some defects in the test.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] snowmantw:bug1191858 > mozilla-b2g:master

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8644418 [details] [review]
[gaia] snowmantw:bug1191858 > mozilla-b2g:master

Julien: I've greped the file and only found one promise as you described. Since it's you reported that, could you take a look? I've tested it manually that now the |transferTo| and |transferOut| will be executed after calling |transfer|, which is the test is for. Thanks.

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 8644418 [details] [review]
[gaia] snowmantw:bug1191858 > mozilla-b2g:master

yes, this looks better. r=me for the test changes

Did you check if subject.transfer is called somewhere in the code though ? I had the impression it's called nowhere...

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

It is called as every new event/input comes as:

    this.nextStep(this.transfer.bind(this, inputs));

It's because manager now needs to handle async conditions that was not in the original design.

Comment 5

[Julien Wajsberg [:julienw]]

Ah right, now I see it; I grepped for 'transfer(' :) Thanks !

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

Patch modified.

Comment 7

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/bb666efba51e14d4c7f4267aef02b4ccff2c913a