Closed Bug 1191858 Opened 5 years ago Closed 5 years ago
Screen] Fix |transfer| test in state manager unit tests
Julien has found some defects in the test.
Comment on attachment 8644418 [details] [review] [gaia] snowmantw:bug1191858 > mozilla-b2g:master Julien: I've greped the file and only found one promise as you described. Since it's you reported that, could you take a look? I've tested it manually that now the |transferTo| and |transferOut| will be executed after calling |transfer|, which is the test is for. Thanks.
Attachment #8644418 - Flags: review?(felash)
Comment on attachment 8644418 [details] [review] [gaia] snowmantw:bug1191858 > mozilla-b2g:master yes, this looks better. r=me for the test changes Did you check if subject.transfer is called somewhere in the code though ? I had the impression it's called nowhere...
Attachment #8644418 - Flags: review?(felash) → review+
It is called as every new event/input comes as: this.nextStep(this.transfer.bind(this, inputs)); It's because manager now needs to handle async conditions that was not in the original design.
Ah right, now I see it; I grepped for 'transfer(' :) Thanks !
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S4 (07Aug)
You need to log in before you can comment on or make changes to this bug.