remove superfluous check for GCC force_align_arg_pointer attribute

RESOLVED FIXED in Firefox 42

Status

defect
RESOLVED FIXED
4 years ago
a year ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla42

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 years ago
qcms and libav use __attribute__((force_align_arg_pointer))
unconditionally; the libav use case suggests that the attribute has been
around since GCC 4.2.  We're well past that, so we needn't check for the
compiler supporting it anymore; we can simply assume GCC has it.
Assignee

Comment 1

4 years ago
The logic in the moz.build could probably be cleaned up a little more, but I
left further simplifications for later.
Attachment #8644451 - Flags: review?(mh+mozilla)
Comment on attachment 8644451 [details] [diff] [review]
remove superfluous check for GCC force_align_arg_pointer attribute

Review of attachment 8644451 [details] [diff] [review]:
-----------------------------------------------------------------

It is worth noting (so please add this information somehow in the commit message) that clang also supports it, and that both compilers support it on x86 but not x86-64. So the tests in the source tree are fine without anything more.
Attachment #8644451 - Flags: review?(mh+mozilla) → review+
Relatedly, it might be worth adding an unconditional -Werror=attributes to our builds, so that we detect unexpectedly used attributes. Because in some cases ignoring unsupported attributes could have bad consequences.
https://hg.mozilla.org/mozilla-central/rev/6f7075c3966f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.