Closed
Bug 1191935
Opened 9 years ago
Closed 9 years ago
Final strings for PBM for Tracking Protection
Categories
(Firefox :: Private Browsing, defect, P1)
Firefox
Private Browsing
Tracking
()
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: javaun, Assigned: bgrins)
References
Details
(Whiteboard: [fxprivacy] [copy needed] [strings] [campaign])
Attachments
(5 files)
We're finalizing all strings for TP/PBM in Fx42. This bug will hold updated strings that need to land by 8/10
Reporter | ||
Updated•9 years ago
|
Flags: qe-verify+
Flags: firefox-backlog+
Priority: -- → P1
Whiteboard: [fxprivacy] [copy needed] [strings] [campaign]
Reporter | ||
Updated•9 years ago
|
Summary: Updated strings for PBM for Tracking Protection → Final strings for PBM for Tracking Protection
Updated•9 years ago
|
Flags: qe-verify+ → qe-verify-
Reporter | ||
Comment 1•9 years ago
|
||
The built-in page is dramatically different because Matej edited it for the first time tonight. I will file Built-in page string changes separately. Otherwise, the changes are minor. Full screenshots are here (greyed out = they aren't subject to string freeze bc they're shipping later or are in UI tour) https://docs.google.com/document/d/134Ez8FpoMVkJ72a4ux8t6mPVNTU8iNPwAa5On4cUQwU/edit?pli=1# Location means where it lives in UI. Old = old string, NEW = new. ------------- Location: Preferences > Privacy Old: Stop sites from tracking you in Private Windows NEW: Enable Tracking Protection in Private Windows ------------- Location: Tracking Protection Control (Enabled) Old: Firefox is blocking attempts to track your browsing. NEW: Firefox is blocking elements that may track your browsing. ------------- Location: Tracking Protection Control (Disabled) Old: This site includes content that tracks your browsing. You have disabled protection. NEW: This site includes elements that may track your browsing. You have disabled protection. ------------- Location: Tracking Protection Control (No elements on page) Old: This site doesn’t include any content that tracks your browsing. NEW: No tracking elements detected on this page. -------------
Assignee | ||
Comment 2•9 years ago
|
||
Bug 1191935 - Update Tracking Protection strings;r=paolo
Attachment #8644726 -
Flags: review?(paolo.mozmail)
Updated•9 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Iteration: --- → 42.3 - Aug 10
Reporter | ||
Comment 3•9 years ago
|
||
(In reply to Javaun Moradi [:javaun] from comment #1) Aislinn suggests "parts of the page". NI'ing Ash. A suggestion for swapping "elements" with "parts of the page" > ------------- > > Location: Tracking Protection Control (Enabled) > Old: Firefox is blocking attempts to track your browsing. > NEW: Firefox is blocking parts of the page that may track your browsing. > > ------------- >
Comment 4•9 years ago
|
||
I believe the old privacy.xul dialog will also need to be updated, because there are tests that open it and will be broken by the missing entity.
Comment 5•9 years ago
|
||
Comment on attachment 8644726 [details] MozReview Request: Bug 1191935 - Update Tracking Protection strings;r=paolo Clearing review flag while discussing the possible updates above.
Attachment #8644726 -
Flags: review?(paolo.mozmail)
Updated•9 years ago
|
Points: --- → 1
Assignee | ||
Comment 6•9 years ago
|
||
Assignee | ||
Comment 7•9 years ago
|
||
Assignee | ||
Comment 8•9 years ago
|
||
Assignee | ||
Comment 9•9 years ago
|
||
Assignee | ||
Comment 10•9 years ago
|
||
Uploaded screenshots of the strings. Javaun, can you take a look?
Flags: needinfo?(jmoradi)
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8644726 [details] MozReview Request: Bug 1191935 - Update Tracking Protection strings;r=paolo Bug 1191935 - Update Tracking Protection strings;r=paolo
Attachment #8644726 -
Flags: review?(paolo.mozmail)
Comment 12•9 years ago
|
||
Comment on attachment 8644726 [details] MozReview Request: Bug 1191935 - Update Tracking Protection strings;r=paolo https://reviewboard.mozilla.org/r/15317/#review13737 ::: browser/locales/en-US/chrome/browser/preferences/privacy.dtd:11 (Diff revision 2) > -<!ENTITY trackingProtection4.accesskey "m"> > +<!ENTITY trackingProtection5.accesskey "m"> Just ensure you update the access keys, if possible, with a letter included in the sentence.
Attachment #8644726 -
Flags: review?(paolo.mozmail) → review+
Assignee | ||
Comment 13•9 years ago
|
||
(In reply to :Paolo Amadini from comment #12) > Comment on attachment 8644726 [details] > MozReview Request: Bug 1191935 - Update Tracking Protection strings;r=paolo > > https://reviewboard.mozilla.org/r/15317/#review13737 > > ::: browser/locales/en-US/chrome/browser/preferences/privacy.dtd:11 > (Diff revision 2) > > -<!ENTITY trackingProtection4.accesskey "m"> > > +<!ENTITY trackingProtection5.accesskey "m"> > > Just ensure you update the access keys, if possible, with a letter included > in the sentence. Looks like "i" is available for "Use Tracking Protection" and "v is available for "Use Tracking Protection in Private Windows" so I'll use those.
Reporter | ||
Comment 14•9 years ago
|
||
Bgrins: approved, screenshots look great.
Flags: needinfo?(jmoradi)
Assignee | ||
Comment 15•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4246db16a1de
https://hg.mozilla.org/mozilla-central/rev/eb46ecd87491
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment 18•9 years ago
|
||
Looks like you forgot to update the accesskeys before landing: <!ENTITY trackingProtectionPBM5.label "Use Tracking Protection in Private Windows"> <!ENTITY trackingProtectionPBM5.accesskey "y">
Updated•9 years ago
|
Flags: needinfo?(bgrinstead)
Assignee | ||
Comment 19•9 years ago
|
||
(In reply to Théo Chevalier [:tchevalier] from comment #18) > Looks like you forgot to update the accesskeys before landing: > > <!ENTITY trackingProtectionPBM5.label "Use Tracking Protection in > Private Windows"> > <!ENTITY trackingProtectionPBM5.accesskey "y"> Doh! Is it too late to push changed accesskeys without bumping the IDs?
Flags: needinfo?(bgrinstead) → needinfo?(theo)
Comment 20•9 years ago
|
||
It's safe to update the accesskey without updating entity, since localizers will pick different accesskey anyway.
Flags: needinfo?(theo)
You need to log in
before you can comment on or make changes to this bug.
Description
•