Final strings for PBM for Tracking Protection

RESOLVED FIXED in Firefox 42

Status

()

defect
P1
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: javaun, Assigned: bgrins)

Tracking

unspecified
Firefox 42
Points:
1
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox42 fixed)

Details

(Whiteboard: [fxprivacy] [copy needed] [strings] [campaign])

Attachments

(5 attachments)

Reporter

Description

4 years ago
We're finalizing all strings for TP/PBM in Fx42. This bug will hold updated strings that need to land by 8/10
Reporter

Updated

4 years ago
Flags: qe-verify+
Flags: firefox-backlog+
Priority: -- → P1
Whiteboard: [fxprivacy] [copy needed] [strings] [campaign]
Reporter

Updated

4 years ago
Summary: Updated strings for PBM for Tracking Protection → Final strings for PBM for Tracking Protection
Flags: qe-verify+ → qe-verify-
Reporter

Comment 1

4 years ago
The built-in page is dramatically different because Matej edited it for the first time tonight. I will file Built-in page string changes separately. Otherwise, the changes are minor.

Full screenshots are here (greyed out = they aren't subject to string freeze bc they're shipping later or are in UI tour)

https://docs.google.com/document/d/134Ez8FpoMVkJ72a4ux8t6mPVNTU8iNPwAa5On4cUQwU/edit?pli=1#


Location means where it lives in UI. Old = old string, NEW = new.
-------------

Location: Preferences > Privacy
Old: Stop sites from tracking you in Private Windows
NEW: Enable Tracking Protection in Private Windows 


-------------


Location: Tracking Protection Control (Enabled)
Old: Firefox is blocking attempts to track your browsing.
NEW: Firefox is blocking elements that may track your browsing. 

-------------


Location: Tracking Protection Control (Disabled)
Old: This site includes content that tracks your browsing. You have disabled protection.
NEW: This site includes elements that may track your browsing. You have disabled protection.

-------------


Location: Tracking Protection Control (No elements on page)
Old: This site doesn’t include any content that tracks your browsing.
NEW: No tracking elements detected on this page.

-------------
Assignee

Comment 2

4 years ago
Bug 1191935 - Update Tracking Protection strings;r=paolo
Attachment #8644726 - Flags: review?(paolo.mozmail)
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Iteration: --- → 42.3 - Aug 10
Reporter

Comment 3

4 years ago
(In reply to Javaun Moradi [:javaun] from comment #1)
Aislinn suggests "parts of the page". NI'ing Ash.

A suggestion for swapping "elements" with "parts of the page"
> -------------
> 
> Location: Tracking Protection Control (Enabled)
> Old: Firefox is blocking attempts to track your browsing.
> NEW: Firefox is blocking parts of the page that may track your browsing. 
> 
> -------------
>
I believe the old privacy.xul dialog will also need to be updated, because there are tests that open it and will be broken by the missing entity.

Comment 5

4 years ago
Comment on attachment 8644726 [details]
MozReview Request: Bug 1191935 - Update Tracking Protection strings;r=paolo

Clearing review flag while discussing the possible updates above.
Attachment #8644726 - Flags: review?(paolo.mozmail)
Points: --- → 1
Assignee

Comment 6

4 years ago
Posted image tp-block.png
Assignee

Comment 7

4 years ago
Posted image tp-load.png
Assignee

Comment 8

4 years ago
Posted image tp-none.png
Assignee

Comment 9

4 years ago
Posted image tp-pref.png
Assignee

Comment 10

4 years ago
Uploaded screenshots of the strings.  Javaun, can you take a look?
Flags: needinfo?(jmoradi)
Assignee

Comment 11

4 years ago
Comment on attachment 8644726 [details]
MozReview Request: Bug 1191935 - Update Tracking Protection strings;r=paolo

Bug 1191935 - Update Tracking Protection strings;r=paolo
Attachment #8644726 - Flags: review?(paolo.mozmail)

Comment 12

4 years ago
Comment on attachment 8644726 [details]
MozReview Request: Bug 1191935 - Update Tracking Protection strings;r=paolo

https://reviewboard.mozilla.org/r/15317/#review13737

::: browser/locales/en-US/chrome/browser/preferences/privacy.dtd:11
(Diff revision 2)
> -<!ENTITY trackingProtection4.accesskey "m">
> +<!ENTITY trackingProtection5.accesskey "m">

Just ensure you update the access keys, if possible, with a letter included in the sentence.
Attachment #8644726 - Flags: review?(paolo.mozmail) → review+
Assignee

Comment 13

4 years ago
(In reply to :Paolo Amadini from comment #12)
> Comment on attachment 8644726 [details]
> MozReview Request: Bug 1191935 - Update Tracking Protection strings;r=paolo
> 
> https://reviewboard.mozilla.org/r/15317/#review13737
> 
> ::: browser/locales/en-US/chrome/browser/preferences/privacy.dtd:11
> (Diff revision 2)
> > -<!ENTITY trackingProtection4.accesskey "m">
> > +<!ENTITY trackingProtection5.accesskey "m">
> 
> Just ensure you update the access keys, if possible, with a letter included
> in the sentence.

Looks like "i" is available for "Use Tracking Protection" and "v is available for "Use Tracking Protection in Private Windows" so I'll use those.
Reporter

Comment 14

4 years ago
Bgrins: approved, screenshots look great.
Flags: needinfo?(jmoradi)
https://hg.mozilla.org/mozilla-central/rev/eb46ecd87491
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Looks like you forgot to update the accesskeys before landing:

<!ENTITY trackingProtectionPBM5.label         "Use Tracking Protection in Private Windows">
<!ENTITY trackingProtectionPBM5.accesskey     "y">
Flags: needinfo?(bgrinstead)
Assignee

Comment 19

4 years ago
(In reply to Théo Chevalier [:tchevalier] from comment #18)
> Looks like you forgot to update the accesskeys before landing:
> 
> <!ENTITY trackingProtectionPBM5.label         "Use Tracking Protection in
> Private Windows">
> <!ENTITY trackingProtectionPBM5.accesskey     "y">

Doh!  Is it too late to push changed accesskeys without bumping the IDs?
Flags: needinfo?(bgrinstead) → needinfo?(theo)
It's safe to update the accesskey without updating entity, since localizers will pick different accesskey anyway.
Flags: needinfo?(theo)
Assignee

Updated

4 years ago
Depends on: 1192482
You need to log in before you can comment on or make changes to this bug.