If Menu toolbar is shown, then it causes additional indent on top of the window in Fullscreen mode

VERIFIED FIXED

Status

()

defect
--
minor
VERIFIED FIXED
4 years ago
3 years ago

People

(Reporter: arni2033, Assigned: xidorn)

Tracking

(Blocks 1 bug, {regression})

Trunk
Unspecified
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 wontfix, firefox47 wontfix, firefox48 wontfix, firefox49 verified, firefox-esr38 unaffected)

Details

(URL)

Attachments

(3 attachments)

(Reporter)

Description

4 years ago
STR:   (Nightly 42.0a1 (2015-08-06))
1. Make sure you have hidden menu bar, bookmarks bar and title bar
2. Switch to Fullscreen mode
3. Press Alt several times

RESULT:   [watch video]
Part of toolbar (some pixels in height) is visible on the top of the screen

EXPECTATIONS: one of 2 will happen:
A) Nothing
B) I will see all toolbars in their current states (as of non-fullscreen mode), including menu bar, that will be visible. When I press Alt again in this scenario, I expect all toolbars to hide again.
(Reporter)

Updated

4 years ago
OS: Unspecified → Windows 7
(Reporter)

Comment 1

4 years ago
I figured out that it doesn't occur on Release(39), but presented on DevEdition(41) and Nightly(42).
Also, the problem is a bit more serious. STR_2:
1. Right-click Australis menu button -> check "Menu bar"
2. Press F11 to enter Fullscreen mode

RESULT: see attachment. It makes using tabs much more complicated.
Component: Menus → Toolbars and Customization
Keywords: regression
Summary: Pressing ALT in Fullscreen mode causes part of toolbar to appear → If Menu toolbar is shown, then it causes additional indent on top of the window in Fullscreen mode
(Reporter)

Updated

4 years ago
(Reporter)

Updated

4 years ago
(Reporter)

Comment 3

4 years ago
Pay attention that now bug 1192655 is fixed, so only STR in comment 1 works. But this bug is still valid
(Assignee)

Comment 5

3 years ago
This is because the gap was added via the rule:
> #toolbar-menubar:not([moz-collapsed="true"]):not([autohide="true"]) ~ #TabsToolbar {
>   margin-top: 3px;
> }
And since bug 1176233, we no longer use moz-collapsed for collapsing toolbars.
(Assignee)

Updated

3 years ago
Assignee: nobody → bugzilla
Comment on attachment 8755276 [details]
MozReview Request: Bug 1191966 part 1 - Remove rules for unused moz-collapsed attribute. r?dao

We need to keep moz-collapsed support in minimal-xul.css, it's used by add-ons.
Flags: needinfo?(dao+bmo)
Attachment #8755276 - Flags: review?(dao+bmo) → review-
Comment on attachment 8755277 [details]
MozReview Request: Bug 1191966 part 2 - Avoid adding margin-top on tabs toolbar when in fullscreen mode. r?dao

Please use #TabsToolbar:not([inFullscreen])
Attachment #8755277 - Flags: review?(dao+bmo) → review-
(Assignee)

Comment 10

3 years ago
Comment on attachment 8755276 [details]
MozReview Request: Bug 1191966 part 1 - Remove rules for unused moz-collapsed attribute. r?dao

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54506/diff/1-2/
Attachment #8755276 - Flags: review- → review?(dao+bmo)
Attachment #8755277 - Flags: review- → review?(dao+bmo)
(Assignee)

Comment 11

3 years ago
Comment on attachment 8755277 [details]
MozReview Request: Bug 1191966 part 2 - Avoid adding margin-top on tabs toolbar when in fullscreen mode. r?dao

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54508/diff/1-2/
Attachment #8755276 - Flags: review?(dao+bmo) → review+
Attachment #8755277 - Flags: review?(dao+bmo) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Comment 13

3 years ago
This seems to have been landed on mozilla-central a while ago. Not sure why the bug is not updated.

https://hg.mozilla.org/mozilla-central/rev/af0b7a2ad92a
https://hg.mozilla.org/mozilla-central/rev/ef5addc3db7d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Blocks: 1208939
I have reproduced this bug with Nightly 42.0a1 (2015-08-06) on Windows 7 , 64 Bit!

This bug's fix is verified on latest Developer Edition (Aurora) which is 49.0a2 (2016-07-08).

 Build ID  20160708004052

User Agent  Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0
Thanks Maruf Rahman for the tests.
I was also not able to reproduce this issue on Firefox 49.0a2 (2016-07-10) and on Windows 7 x86.
I am marking this issue Verified Fixed.
Status: RESOLVED → VERIFIED
Too late to bring to beta, but this will be fixed in 49 release.
You need to log in before you can comment on or make changes to this bug.