1192055 - [Notification Tray][SHB] UI for Tray drops too low and sets back to top of screen after initial opening/drag-down from top

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[Oliver Nelson [:oliverthor]]

Attachment: logcat_20150806_1546.txt

Description:
When the user drags down the notification tray from within any app, or homescreen, they will observe the UI/status-bar start too low and shift upwards over the course of a second. While on screen, the tray may also be dragged down further, corresponding to where it was drawn initially. This creates a duplicate status bar and bad UI experience.This occurs on Flame devices, but does not occur on Aries.

Repro Steps:
1) Update a Flame to 20150806030207
2) At homescreen, drag from top of screen to summon notification tray
3) Observe UI on tray

Actual:
UI on tray will draw too low, and will shift upwards over the course of a second

Expected:
UI on tray will set at the appropriate level


Environmental Variables:
------------------------------------

Device: Flame 2.5
Build ID: 20150806030207
Gaia: 4ede0c6bf5fb0c2896d5393032b395999a154619
Gecko: 07befc6f54e7
Gonk: 41d3e221039d1c4486fc13ff26793a7a39226423
Version: 42.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0
******************************

Issue DOES NOT OCCUR on:
* 2.2 for flame devices
* master for aries devices
Results: UI on tray will set at the appropriate level

Device: Aries 2.5
BuildID: 20150806111958
Gaia: 497fe3f938722b0aa49c93f975fad5d9ed3b0a82
Gecko: 22476236b3e1
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Device: Flame 2.2
BuildID: 20150806032503
Gaia: f8b119ac30e97df991c97682ac4d4f9ca22e1793
Gecko: a9379f716e9f
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
------------------------------------


Repro frequency: 5/5
See attached: 
video- https://youtu.be/aM5vzK-RqJE
logcat

Comment 1

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
noticeable regression

requesting a window.

Comment 2

[Shally Li（leave from Mozilla）]

b2g-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame KK 2.5
Build ID               20150604012244
Gaia Revision          e0fbadeb78a96137f071d9be7a47ef9fe882d17f
Gaia Date              2015-06-04 07:44:30
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/64ce149fabf1
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150606.193652
Firmware Date          Sat Jun  6 19:37:03 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

First Broken Environmental Variables:
Device: Flame KK 2.5
Build ID               20150604020845
Gaia Revision          c1ef854924f18357832ddcf98dc6c42391d5599e
Gaia Date              2015-06-04 08:39:26
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/4f7e7631e277
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150605.192034
Firmware Date          Fri Jun  5 19:20:46 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

First Broken Gaia & Last Working Gecko - issue DOES repro
Gaia-Rev        c1ef854924f18357832ddcf98dc6c42391d5599e
Gecko-Rev       64ce149fabf1

First Broken Gecko & Last Working Gaia - issue DOES NOT repro
Gaia-Rev        e0fbadeb78a96137f071d9be7a47ef9fe882d17f
Gecko-Rev       4f7e7631e277

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/e0fbadeb78a96137f071d9be7a47ef9fe882d17f...c1ef854924f18357832ddcf98dc6c42391d5599e

Possibly caused by Bug 1094759.

Comment 3

[Shally Li（leave from Mozilla）]

Please note that it need to slide down/up the tray bar before you check/uncheck the SHB, then this bug can be repro.

Comment 4

[Al Tsai [:atsai]]

[Triage] Plus it due to serious UX issue.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1192055-tray-down > mozilla-b2g:master

Comment 6

[Alberto Pastor [:albertopq]]

Comment on attachment 8652827 [details] [review]
[gaia] albertopq:1192055-tray-down > mozilla-b2g:master

The shb transition was hiding this issue. We need to dispatch the software-home-button-enabled/disabled event *after* updating the #screen class.

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8652827 [details] [review]
[gaia] albertopq:1192055-tray-down > mozilla-b2g:master

Works like a charm. Thanks for the tests too. I put some comments on github, but I'll leave it up to you if you want to fix.

Comment 8

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/bbebd1921dbf5656a3b5dca699eebb1aa707b3f4

Comment 9

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest nightly build of Flame KK 2.5 by the STR in comment 0.

Actual results: UI on tray will set at the appropriate level after checking/unchecking SHB.
See attachment: verified_FlameKK_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150830150218
Gaia Revision          31e595f86f6bf159b3a9a46816a6ac00a55ca9f9
Gaia Date              2015-08-30 00:42:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/2ad5077d86ba81b667de45ccc986dbd2ce633cc4
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150830.184031
Firmware Date          Sun Aug 30 18:40:47 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 10

[Shally Li（leave from Mozilla）]

Attachment: verified_FlameKK_v2.5.3gp