Closed
Bug 1192071
Opened 10 years ago
Closed 10 years ago
use llvm-symbolizer when running jit-tests under TSan
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
1.58 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
Just like ASan, TSan can use llvm-symbolizer, except that it requires a
slightly different setup.
| Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8644674 -
Flags: review?(mshal)
Comment 2•10 years ago
|
||
Comment on attachment 8644674 [details] [diff] [review]
use llvm-symbolizer when running jit-tests under TSan
LGTM - I guess it's not useful to have both MOZ_ASAN and MOZ_TSAN enabled? It doesn't look like configure prevents that, so if they're both on only the TSAN flags will be present.
Attachment #8644674 -
Flags: review?(mshal) → review+
| Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Michael Shal [:mshal] from comment #2)
> LGTM - I guess it's not useful to have both MOZ_ASAN and MOZ_TSAN enabled?
clang, at least, will yell at you if you try to compile with both ASan and TSan. I assume GCC does the same.
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•