Closed Bug 1192088 Opened 5 years ago Closed 5 years ago

Final strings for PBM built-in page

Categories

(Firefox :: Private Browsing, defect, P1)

defect
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 42
Iteration:
42.3 - Aug 10
Tracking Status
firefox42 --- fixed

People

(Reporter: javaun, Assigned: Paolo)

References

Details

(Whiteboard: [fxprivacy] [copy needed] [strings] [campaign])

Attachments

(1 file)

Final strings landing in 42 for the PBM built-in page (about:privatebrowsing)
EDITED COPY (full screenshots here: https://docs.google.com/document/d/134Ez8FpoMVkJ72a4ux8t6mPVNTU8iNPwAa5On4cUQwU/edit?pli=1#)

##################################
#[IF TP IS ON]
##################################


Header: Private Browsing

Heading 1:
You’re Browsing Privately

In this window, Firefox will not remember:
* History
* Searches
* Cookies
* Temporary Files

Firefox will keep:
* Downloads
* Bookmarks

Please note that your employer or Internet service provider can still track the pages you visit.

Heading 2:
Tracking Protection

Private Windows now block parts of the page that may track your browsing activity.

Turn Tracking Protection Off (link)

##################################
#[IF TP IS OFF]
##################################

Header: Private Browsing

Heading 1:
You’re Browsing Privately

In this window, Firefox will not remember:
* History
* Searches
* Cookies
* Temporary Files

Firefox will keep:
* Downloads
* Bookmarks

Please note that your employer or Internet service provider can still track the pages you visit.

Heading 2:
Tracking Protection

Private Windows now block parts of the page that may track your browsing activity.

Turn Tracking Protection On (link)
Flags: qe-verify+
Flags: firefox-backlog+
Priority: -- → P1
Whiteboard: [fxprivacy] [copy needed] [strings] [campaign]
Flags: qe-verify+ → qe-verify-
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Iteration: --- → 42.3 - Aug 10
Points: --- → 1
Bug 1192088 - Final strings for the updated about:privatebrowsing design. r=bgrins
Attachment #8645180 - Flags: review?(bgrinstead)
Comment on attachment 8645180 [details]
MozReview Request: Bug 1192088 - Final strings for the updated about:privatebrowsing design. r=bgrins

https://reviewboard.mozilla.org/r/15433/#review13817

From what I've been told it's alright to update the strings in place without updating the entity names since these IDs just landed on fx-team.

::: browser/components/privatebrowsing/content/aboutPrivateBrowsing.xhtml:72
(Diff revision 1)
> -        <p class="showTpEnabled">&trackingProtection.description.enabled;</p>
> +        <p>&trackingProtection.description;</p>

There is CSS that uses these classes, it should be removed before landing
Attachment #8645180 - Flags: review?(bgrinstead) → review+
Comment on attachment 8645180 [details]
MozReview Request: Bug 1192088 - Final strings for the updated about:privatebrowsing design. r=bgrins

Bug 1192088 - Final strings for the updated about:privatebrowsing design. r=bgrins
https://hg.mozilla.org/mozilla-central/rev/be6e180ce096
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Feeling like a party pooper today :/

(In reply to Brian Grinstead [:bgrins] from comment #3)
> From what I've been told it's alright to update the strings in place without
> updating the entity names since these IDs just landed on fx-team.

It would have been fine if it were true (landing only in fx-team), but strings have landed on mozilla-central and have already been translated in several languages.

However for aboutPrivateBrowsing.subtitle, it's not fine, the same entity is already used in Aurora, Beta, release:
https://transvision.mozfr.org/channelcomparison/?locale=en-US&chan1=central&chan2=aurora
Flags: needinfo?(bgrinstead)
Also I assume aboutPrivateBrowsing.info.forgotten and aboutPrivateBrowsing.info.kept can now be removed?
I guess they are replaced with aboutPrivateBrowsing.forgotten and aboutPrivateBrowsing.kept
(In reply to Théo Chevalier [:tchevalier] from comment #7)
> Feeling like a party pooper today :/

Not at all, glad you caught it before the merge.  Forwarding the request onto Paolo to see if he can take a look at this.
Flags: needinfo?(bgrinstead) → needinfo?(paolo.mozmail)
(In reply to Théo Chevalier [:tchevalier] from comment #8)
> Also I assume aboutPrivateBrowsing.info.forgotten and
> aboutPrivateBrowsing.info.kept can now be removed?
> I guess they are replaced with aboutPrivateBrowsing.forgotten and
> aboutPrivateBrowsing.kept

We can remove those strings when we uplift the slightly revised visual design, which didn't reach us in time for string freeze. In the meantime they're still used in place of the new ones.

(In reply to Théo Chevalier [:tchevalier] from comment #7)
> It would have been fine if it were true (landing only in fx-team), but
> strings have landed on mozilla-central and have already been translated in
> several languages.

Heh, this bug landed on the same day of bug 1190427 (less than 4 hours later) but apparently there was a fast merge of fx-team to central in-between, and the next merge was delayed so it's possible translations were started already in this time window!

> However for aboutPrivateBrowsing.subtitle, it's not fine, the same entity is
> already used in Aurora, Beta, release:
> https://transvision.mozfr.org/channelcomparison/?locale=en-
> US&chan1=central&chan2=aurora

Sorry, I've actually overlooked that one. However, that is one of the strings that are slated for removal once we have the new visual design, and it has the same meaning as the previous one, so it might not be worth re-translating after all.
Flags: needinfo?(paolo.mozmail)
Blocks: 1192621
(In reply to :Paolo Amadini from comment #10)
> We can remove those strings when we uplift the slightly revised visual
> design, which didn't reach us in time for string freeze. In the meantime
> they're still used in place of the new ones.

Does it mean that the new design is landing on mozilla-aurora? Are specs available, or is there an open bug for that?

Unfortunately removing the strings once in mozilla-aurora is not useful, but this is going to generate confusion for sure. A comment in the file explaining all this, especially with a link to the new design if it's not going to land at the beginning of the cycle, would at least reduce the confusion.
Blocks: 1192625
(In reply to Francesco Lodolo [:flod] from comment #11)
> Does it mean that the new design is landing on mozilla-aurora? Are specs
> available, or is there an open bug for that?

Yeah, we'll need to uplift it. Specs are not available and I've now filed bug 1192625 for the engineering work.

> Unfortunately removing the strings once in mozilla-aurora is not useful, but
> this is going to generate confusion for sure. A comment in the file
> explaining all this, especially with a link to the new design if it's not
> going to land at the beginning of the cycle, would at least reduce the
> confusion.

I'll add a comment referencing the new bug.
What will be used in 42 and what will be removed or reverted? (and from where)
(In reply to Stefan Plewako [:stef] from comment #13)
> What will be used in 42 and what will be removed or reverted? (and from
> where)

See bug 1192625.
(In reply to Francesco Lodolo [:flod] from comment #14)
> (In reply to Stefan Plewako [:stef] from comment #13)
> > What will be used in 42 and what will be removed or reverted? (and from
> > where)
> 
> See bug 1192625.

Sorry but I don't see clear answer in bug 1192625.
(In reply to Stefan Plewako [:stef] from comment #15)
> Sorry but I don't see clear answer in bug 1192625.

These are the strings that will probably become unused (and removed from mozilla-central):

aboutPrivateBrowsing.subtitle
aboutPrivateBrowsing.info.forgotten
aboutPrivateBrowsing.info.kept

There is also a comment in the DTD file now.

Feel free to follow the conversation in bug 1192625 for more details. This is still subject to change until the design is finalized...
You need to log in before you can comment on or make changes to this bug.