Intermittent test_bug418986-2.xul | -moz-windows-theme should match

NEW
Unassigned

Status

()

Core
Layout
P3
normal
2 years ago
a year ago

People

(Reporter: KWierso, Unassigned)

Tracking

({intermittent-failure, leave-open})

40 Branch
intermittent-failure, leave-open
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Dao, any idea what might be going on here?
Flags: needinfo?(dao)
No, I don't know anything about this test, sorry.
Blocks: 418986
Flags: needinfo?(mrbkap)
Flags: needinfo?(dao)
Flags: needinfo?(arthuredelstein)
Created attachment 8646023 [details] [diff] [review]
0001-Bug-1192090-Add-aero-lite-Windows-theme-to-418986-te.patch

Try server: https://treeherder.mozilla.org/#/jobs?repo=try&revision=efccedd10767dddd
Flags: needinfo?(arthuredelstein)
Attachment #8646023 - Flags: review?(mrbkap)
Blocks: 1193593
Attachment #8646023 - Flags: review?(mrbkap) → review?(cam)

Updated

2 years ago
Flags: needinfo?(mrbkap)
Comment on attachment 8646023 [details] [diff] [review]
0001-Bug-1192090-Add-aero-lite-Windows-theme-to-418986-te.patch

Review of attachment 8646023 [details] [diff] [review]:
-----------------------------------------------------------------

This change looks a good one to make, but I'm assuming it's not a fix for the intermittent failure.

Could you include the specific value in the second argument of the ok() calls of testWindowsSpecific?  That'll make it easier to debug.
Attachment #8646023 - Flags: review?(cam) → review+
Created attachment 8647689 [details] [diff] [review]
0001-Bug-1192090-Add-aero-lite-Windows-theme-to-418986-te.patch

Here's a new version of the reviewed patch, with the change made as requested.
Attachment #8646023 - Attachment is obsolete: true
Try server: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c2db26df858
Keywords: checkin-needed, leave-open

Comment 9

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/110d8b783b5f
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/110d8b783b5f
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)

Comment 15

a year ago
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.