Closed
Bug 1192137
Opened 10 years ago
Closed 10 years ago
[Stingray] Remove unused script tag and link tag in Smart Home
Categories
(Firefox OS Graveyard :: Gaia::TV::Home, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dwi2, Assigned: dwi2)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150804004026
Steps to reproduce:
these two lines are already unused:
<link rel="stylesheet" type="text/css" href="style/modal_dialog.css">
<script defer src="js/modal_dialog.js"></script>
and already replace by smart-modal-dialog (https://github.com/smart-components/smart-modal-dialog)
|
||
Comment 1•10 years ago
|
||
|
||
Updated•10 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8644802 [details] [review]
[gaia] dwi2:bug1192137 > mozilla-b2g:master
Hi John,
This is a simple patch to remove redundant script and link tag in smart-home. Please help to review it. Thanks
Attachment #8644802 -
Flags: review?(im)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8644802 [details] [review]
[gaia] dwi2:bug1192137 > mozilla-b2g:master
Looks good to me. Thanks.
Attachment #8644802 -
Flags: review?(im) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Thanks
Landed in master
https://github.com/mozilla-b2g/gaia/commit/fa89e03dc489e79baa0e74cb1d205260c7924caa
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•