119214 - crash enabling FIPS mode in NSS 3.4

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P1)

Description

[Ian McGreer]

I was playing with David's test code from bug 119059, and modified it to switch
back and forth between FIPS mode.  After disabling FIPS (causing a load of the
softoken), a call to PK11_GetInternalKeySlot() will crash because the internal
module only has one slot.

Comment 1

[Ian McGreer]

Attachment: test program

run program once to enable FIPS, then again to disable, crash.

Comment 2

[Ian McGreer]

Attachment: patch needed for FIPS (but does not fix crash)

I'm including this patch here, which is part of what is needed to get FIPS
working.  It does not fix the crash, however.  The crash happens completely
outside of Stan code.  When the internal SECMODModule is loaded, it only has
one slot.

Comment 3

[Robert Relyea]

Sounds like a bug I need to look at.

Comment 4

[Robert Relyea]

The only way GetInternalKeySlot will try to reference a second slot is if
mod->isFIPS is False. 
(follows is the relevent code from PK11_GetInternalKeySlot)

return PK11_ReferenceSlot(mod->isFIPS ? mod->slots[0] : mod->slots[1]);

So this can only crash if mod->slots[0] is invalid, or mod->isFIPS is
incorrectly set). I'll take a look at which.

bob

Comment 5

[Robert Relyea]

Fix checked in to tip

Comment 6

[Bishakha Banerjee]

Attachment: manifest file

First in the series of test programs that will go into
mozilla/nss/security/cmd/tests.

Since this already has a test program written, good candidate to try out the
build procedure.  I will start attaching the other test programs for review for

checkin after the makefiles, etc. for this are approved.
Attaching makefile, and manifest file for review. Also attaching slightly
modified testfile.

The idea for the makefiles is that there will be one Makefile for the cmd/tests
directory, and each new test program will just be added to it.


this is the manifest file

Comment 7

[Bishakha Banerjee]

Attachment: makefile

attaching the makefile

Comment 8

[Bishakha Banerjee]

Attachment: test file

Attaching previously written test program, slightly modified

Comment 9

[Bishakha Banerjee]

changed QA contact to myself

Comment 10

[Bishakha Banerjee]

Comment on attachment 83102 [details]
manifest file

Marking this attachment obsolete as duplicated in bug 144316, where Wan-Teh has
the right manifest file.

Comment 11

[Bishakha Banerjee]

Comment on attachment 83103 [details]
makefile

Marking this attachment obsolete as duplicate of bug 144316, where Wan-Teh has
the right Makefile