Closed Bug 1192155 Opened 6 years ago Closed 6 years ago

URL bar should not send manually-entered URLs to search suggestion provider

Categories

(Firefox for iOS :: Browser, defect)

All
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
fxios + ---

People

(Reporter: cpeterson, Assigned: sleroux)

Details

(Whiteboard: [1.1?])

Attachments

(1 file)

Sending URLs I am entering to a search engine just feels creepy. URLs can contain more private or personal data than just a domain name or search terms. Safari doesn't send send URL-like strings, but iOS Chrome does.

I suggest that Fennec following Safari's behavior: stop requesting search suggestions when the entered string contains a forward slash "/". Don't stop on dot "." (e.g. "cnn.com") because legitimate search queries might have dots (e.g. "mr. roboto") and suggestions for domain names can be useful. If the user enters a space " ", then the string is not a (canonical) URL, so start showing search suggestions again.

In Safari, entering "cnn.com/i" will stop showing search suggestions because the query looks like a URL. But if you enter a space and a second search term (e.g. "cnn.com/i n"), then Safari starts showing search suggestions again.

In iOS Chrome, entering "cnn.com/i" will keep showing search suggestions (suggesting URLs).
Seems legit, but also some riskier edge cases. I don't think we should block 1.0 on this, but let's see what the triage crew says.
Hardware: Other → All
Whiteboard: [1.1?]
Assignee: nobody → sleroux
Attachment #8652888 - Attachment is patch: true
Attachment #8652888 - Attachment mime type: text/x-github-pull-request → text/plain
Attachment #8652888 - Flags: review?(bnicholson) → review+
Merged
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.