Closed Bug 1192198 Opened 6 years ago Closed 6 years ago

Log viewer should count a step result of "skipped" the same as "success"

Categories

(Tree Management :: Treeherder: Log Viewer, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: emorley, Assigned: jfrench)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
emorley
: review+
Details | Review
Currently the log viewer displays only failed steps, unless the "show successful steps" checkbox is ticked (or there are no failed steps at all).

However a step with status of "skipped" is counted as failed, which if all steps had a status of "success" except one that has a status of "skipped", then the log viewer doesn't show the successful steps by default. eg:
https://treeherder.allizom.org/logviewer.html#?job_id=9117571&repo=mozilla-inbound

We should make hasFailedSteps() return False for both the result state of "skipped" as well as "success":
https://github.com/mozilla/treeherder/blob/d0bb90a2eefd49deb31349a7a6f5caa1d71d5069/ui/js/controllers/logviewer.js#L54
Assignee: nobody → tojonmz
Blocks: 1182178
Status: NEW → ASSIGNED
OS: Unspecified → All
Hardware: Unspecified → All
Attached file PR 847
Please see tweak PR for review, hopefully this addresses the scenarios correctly.
Attachment #8645091 - Flags: review?(emorley)
Attachment #8645091 - Flags: review?(emorley) → review+
Marking fixed per above merge. Will verify on the next push to stage/prod.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Verified fixed on stage and prod.

There may be some other cases to handle, but this particular bug appears fixed. We display skipped steps by default in failed jobs, and display all successful steps and skipped steps by default for successful jobs.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.