119220 - Occurances of uninitialized variables being used before being set.

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[Aleksey Nogin]

From http://tinderbox.mozilla.org/SeaMonkey/warn1010629440.4199.html:

netwerk/base/public/nsReadLine.h:63
   `char eolchar' might be used uninitialized in this function

netwerk/base/src/nsFileTransport.cpp:932
   `PRUint32 total' might be used uninitialized in this function

netwerk/base/src/nsStandardURL.cpp:1641
   `nsresult rv' might be used uninitialized in this function

netwerk/streamconv/converters/nsFTPDirListingConv.cpp:952
   `long unsigned int size' might be used uninitialized in this function

netwerk/test/TestPageLoad.cpp:198
   `nsresult rv' might be used uninitialized in this function

netwerk/test/TestSocketTransport.cpp:421
   `nsresult rv' might be used uninitialized in this function

P.S. This is a "next generation" bug 59661

Comment 1

[Doug Turner (:dougt)]

neeti, lets address this for 0.99

Comment 2

[neeti]

Attachment: patch which fixes these warnings

Comment 3

[neeti]

The above patch fixes all the warnings, except

netwerk/base/src/nsStandardURL.cpp:1641
   `nsresult rv' might be used uninitialized in this function

which was fixed by bug 119330

darin,doug: could you review the patch.

Comment 4

[Darin Fisher]

Comment on attachment 69283 [details] [diff] [review]
patch which fixes these warnings

sr=darin

thx for cleaning these up

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 69283 [details] [diff] [review]
patch which fixes these warnings

even if we have the wrong values defaulted, we are at least consistent. :-)

Comment 6

[neeti]

fix checked in

Comment 7

[Aleksey Nogin]

Verifying - warnings are gone on TBox.