Closed Bug 119220 Opened 18 years ago Closed 18 years ago

Occurances of uninitialized variables being used before being set.

Categories

(Core :: Networking, defect)

x86
Linux
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla0.9.9

People

(Reporter: mozilla-bugs, Assigned: neeti)

References

Details

Attachments

(1 file)

From http://tinderbox.mozilla.org/SeaMonkey/warn1010629440.4199.html:

netwerk/base/public/nsReadLine.h:63
   `char eolchar' might be used uninitialized in this function

netwerk/base/src/nsFileTransport.cpp:932
   `PRUint32 total' might be used uninitialized in this function

netwerk/base/src/nsStandardURL.cpp:1641
   `nsresult rv' might be used uninitialized in this function

netwerk/streamconv/converters/nsFTPDirListingConv.cpp:952
   `long unsigned int size' might be used uninitialized in this function

netwerk/test/TestPageLoad.cpp:198
   `nsresult rv' might be used uninitialized in this function

netwerk/test/TestSocketTransport.cpp:421
   `nsresult rv' might be used uninitialized in this function

P.S. This is a "next generation" bug 59661
Blocks: 59652
neeti, lets address this for 0.99
Target Milestone: --- → mozilla0.9.9
The above patch fixes all the warnings, except

netwerk/base/src/nsStandardURL.cpp:1641
   `nsresult rv' might be used uninitialized in this function

which was fixed by bug 119330

darin,doug: could you review the patch.
Comment on attachment 69283 [details] [diff] [review]
patch which fixes these warnings

sr=darin

thx for cleaning these up
Attachment #69283 - Flags: superreview+
Comment on attachment 69283 [details] [diff] [review]
patch which fixes these warnings

even if we have the wrong values defaulted, we are at least consistent. :-)
Attachment #69283 - Flags: review+
fix checked in
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Verifying - warnings are gone on TBox.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.