Closed
Bug 1192236
Opened 9 years ago
Closed 9 years ago
Fix program invocation in Gaia's makefile
Categories
(Firefox OS Graveyard :: GonkIntegration, defect)
Tracking
(b2g-master fixed)
RESOLVED
FIXED
FxOS-S5 (21Aug)
| Tracking | Status | |
|---|---|---|
| b2g-master | --- | fixed |
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(2 files)
This is a follow-up to bug 1188310. Even after landing the patch, I noticed errors about missing programs. Turns out that the makefile assigns 'which node' to a variable *without* actually executing it. Other tests in the makefile consequently fail and show invalid error messages. The correct way to run this code is by the use of $(shell).
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Comment 2•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8644946 -
Flags: review?(mwu)
|
||
Updated•9 years ago
|
Attachment #8644946 -
Flags: review?(mwu) → review+
|
||
Comment 4•9 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/ce2a1760b1d130cb24b53080e67dddf8b68b9de2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-b2g-master:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S5 (21Aug)
You need to log in
before you can comment on or make changes to this bug.
Description
•