1192243 - [Gtk3] Crash reporter is broken: ScrolledWindow has height of zero

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Petr Jašíček]

Attachment: crash reporter dialog.tar.xz

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150518070114

Steps to reproduce:

The Mozilla Firefox crash reporter is barely usable since it fails to set correct sizes for Gtk Widgets with scrollbars and GtkLabel's lines are not breaking.

Version-Release number of selected component (if applicable):
gtk3-3.16.5-1.fc22.x86_64
firefox-38.0.1-1.fc22.x86_64

How reproducible:
always

Steps to Reproduce:
1. Start firefox with Gtk3 backend (Fedora 22)
2. Send SIGABRT to firefox, the crash reporter will now open
3. try to use the crash reporter


Actual results:

See attached screenshots. Screenshot 1 shows the crash reporter. When clicking on "Details" you will see Screenshot 2.


Expected results:

Crash reporter should mostly look as in Gtk2.

Comment 1

[Petr Jašíček]

Attachment: 001_gtk3_crash_reporter_fix.patch

The main reason why this is happening is that gtk_widget_set_size_request() does not work properly in Gtk3 which in this case affects the GtkScrolledWindow's size and GtkLabel's size. 

Other thing is that if GtkScrolledWindow has GTK_POLICY_NEVER set on horizontal scrollbar, then the embedded GtkTextView's width is as wide as the longest line. Also in Gtk3 the GtkScrolledWindow does not resize automatically with the dialog window, which is why vexpand is set to TRUE.

Comment 2

[Karl Tomlinson (:karlt)]

Comment on attachment 8644956 [details] [diff] [review]
001_gtk3_crash_reporter_fix.patch

>+#if (MOZ_WIDGET_GTK == 2)
>   gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(scrolled),
>                                  GTK_POLICY_NEVER, GTK_POLICY_ALWAYS);

>+#else
>+  gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(scrolled),
>+                                 GTK_POLICY_AUTOMATIC, GTK_POLICY_ALWAYS);
>+  gtk_widget_set_vexpand(scrolled, TRUE);
>+#endif

Would these changes be fine with GTK2?

If so, please remove the #if (MOZ_WIDGET_GTK == 2) block.

Comment 3

[Petr Jašíček]

Attachment: patch for check-in

Copying review+ from last comment.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00ebb26cab7f

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00ebb26cab7f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/00ebb26cab7f