1192255 - NUWA assertion with Msg_LastPrivateDocShellDestroyed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Gregor Wagner [:gwagner]]

Attachment: gdb bt

Seen during monkey testing on aries with debug gecko.

Comment 1

[Cervantes Yu [:cyu] [:cervantes]]

We shouldn't send last-pb-context-exited to Nuwa since there won't be browsing activities in it.

Comment 2

[Cervantes Yu [:cyu] [:cervantes]]

On a closer look, ContentParent::Observe() is really a mess w.r.t. Nuwa process. There needs to be compile-time and runtime checks, which is error-prone.

Given that only few notifications are safe to the ready Nuwa process, we need a cleaner way to do it in ContentParent. The current idea is unregistering the Nuwa process of those notifications once ready, only leaving the notifications that are necessary.

Comment 4

[Cervantes Yu [:cyu] [:cervantes]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=69c1c210a47f

Comment 5

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Clean up ContentParent's observer topics for the Nuwa process.

Comment 6

[Cervantes Yu [:cyu] [:cervantes]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ea1868dc379

Comment 7

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Clean up ContentParent's observer topics for the Nuwa process.

Update to the previous patch: fix the build failures on non-Nuwa platforms for handling "nsPref:Changed".

Comment 8

[Cervantes Yu [:cyu] [:cervantes]]

Comment on attachment 8648001 [details] [diff] [review]
Clean up ContentParent's observer topics for the Nuwa process.

Cancel the request since this revision has regressions. Retest on try and will update the patch once the results are green.

Comment 9

[Cervantes Yu [:cyu] [:cervantes]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=83ed37117ab8

Comment 10

[Cervantes Yu [:cyu] [:cervantes]]

Comment on attachment 8648001 [details] [diff] [review]
Clean up ContentParent's observer topics for the Nuwa process.

Windows 8 browser chrome tests looks good. Request review for the patch.

Comment 12

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8648001 [details] [diff] [review]
Clean up ContentParent's observer topics for the Nuwa process.

Review of attachment 8648001 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/ipc/ContentParent.cpp
@@ +3018,5 @@
>          return NS_OK;
>  
> +    // The Nuwa process unregisters the topics after it becomes ready except for
> +    // the ones listed in sNuwaSafeObserverTopics. If the topic needs to be
> +    // observed by the Nuwa process, either for:

s/ for//

@@ +3024,5 @@
> +    // 1.1 The state can safely happen (only run on the main thread) in the Nuwa
> +    //     process (e.g. "a11y-init-or-shutdown"), or
> +    // 1.2 The topic doesn't send an IPC message (e.g. "xpcom-shutdown").
> +    // 2. The topic needs special handling (e.g. nsPref:Changed),
> +    // add the topic to sNuawSafeObserverTopics and then handle it if necessary.

sNuwa...

Comment 13

[Cervantes Yu [:cyu] [:cervantes]]

url:        https://hg.mozilla.org/integration/b2g-inbound/rev/c46f4154cceac710d34729778b2528f1422962e0
changeset:  c46f4154cceac710d34729778b2528f1422962e0
user:       Cervantes Yu <[e-mail]>
date:       Fri Aug 14 15:41:54 2015 +0800
description:
Bug 1192255: Clean up ContentParent's observer topics for the Nuwa process. r=khuey

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c46f4154ccea