1192312 - Use MediaCodecSource for camera recording since gonk L

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Sotaro Ikeda [:sotaro]]

+++ This bug was initially created as a clone of Bug #1187364 +++

Since android L, MediaCodecSource is used instead of OMXCodec. MediaCodec expose more capability than OMXCodec, it seems better to use MediaCodecSource if possible.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use MediaCodecSource for camera recording since gonk L

Comment 2

[Sotaro Ikeda [:sotaro]]

I confirmed that attachment 8645034 [details] [diff] [review] works on master nexus-5-l.

Comment 3

[Sotaro Ikeda [:sotaro]]

FYI: Diagram of MediaCodecSource related classes.
 https://github.com/sotaroikeda/android-diagrams/blob/master/media/MediaCodecSource_5.1.pdf

Comment 4

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9345b4c6a8e6

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 8645034 [details] [diff] [review]
patch - Use MediaCodecSource for camera recording since gonk L

Review of attachment 8645034 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with some minor nits.

::: dom/camera/GonkRecorder.cpp
@@ +1367,5 @@
> +        // release the camera source due to the camera's lock
> +        // and unlock mechanism.
> +        if (cameraSource != NULL) {
> +            cameraSource->stop();
> +        }

Is this check necessary? It shouldn't be null, and if it is, we should fail in setupMPEG4Recording and setupMPEG2TSRecording before calling setupVideoEncoder.

Comment 6

[Sotaro Ikeda [:sotaro]]

(In reply to Andrew Osmond [:aosmond] from comment #5)
> 
> Is this check necessary? It shouldn't be null, and if it is, we should fail
> in setupMPEG4Recording and setupMPEG2TSRecording before calling
> setupVideoEncoder.

On b2g, the check is not necessary. I am going to remove it. It exists on android to support video source surface.

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use MediaCodecSource for camera recording since gonk L

Apply the comment. Carry "r=aosmond".

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/db0d6f44e3e9

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/db0d6f44e3e9

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/334e382cb408