1192315 - Support remainder arguments from predefined parsers in mach.

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[James Graham [:jgraham]]

Mach has special handling for remainder arguments which currently
    only worked with the decoration form. Extend this to also work when
    a command passes in an explicit parser

Comment 1

[James Graham [:jgraham]]

Attachment: MozReview Request: Bug 1192315 - Support remainder arguments from predefined parsers in mach, r?gps

Bug 1192315 - Support remainder arguments from predefined parsers in mach, r?gps
Mach has special handling for remainder arguments which previously
only worked with the decoration form. Extend this to also work when
a command passes in an explict parser

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8645037 [details]
MozReview Request: Bug 1192315 - Support remainder arguments from predefined parsers in mach, r?gps

https://reviewboard.mozilla.org/r/15361/#review13811

::: python/mach/mach/dispatcher.py:190
(Diff revision 1)
> +                    subparser._actions.remove(arg)

This will cause issues if the parser instance is used elsewhere. I don't think this is worth worrying about, however.

Comment 3

[James Graham [:jgraham]]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/8091ada4f6f36678c33a7c50e7935fa0fa342a6c
changeset:  8091ada4f6f36678c33a7c50e7935fa0fa342a6c
user:       James Graham <[e-mail]>
date:       Fri Aug 07 18:13:05 2015 +0100
description:
Bug 1192315 - Support remainder arguments from predefined parsers in mach, r=gps

Mach has special handling for remainder arguments which previously
only worked with the decoration form. Extend this to also work when
a command passes in an explict parser

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8091ada4f6f3